-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate test
npm package
#928
Comments
Alternative take: it would be great to bring that module up to date. The delta between |
That could be done, I just feel that there should be a point where this module reaches the end of its lifespan. IMHO it shouldn't be a polyfill/shim forever. Maybe it's okay now that the test runner was added recently, but in a few years, maybe this module should eventually be deprecated. |
I've looked into upgrading the package, and I'm afraid it's not that simple. The test runner now makes use of |
In userland code, it might be enough to use dynamic import. |
Last time I tried upgrading the |
Yeah because that package is using a different set of lint rules, there are lots of conflicts to fix every time we try to backport something. At this point, we should probably disable the linter on files maintained on nodejs/node. (or indeed, deprecate the package) |
I also tried upgrading, but there are so many things that are extremely complicated to include. (My progress: 34/35 passing tests)
|
Okay. I've upgraded the package to v23, but with the amount of work it took, and the likelyhood of it being out-of-date again in only a few months, I still think deprecation is the way to go. |
hey! Just ran into this with one of my older packages. I'd strongly urge us to keep this going, as it does allow for the option to decouple your tests from your runtime - having to do test and runtime upgrades at the same time does add burden, and being able to swap over to Further, generally people update their runtime less frequently than they update their dependencies. Having the separate package enables people to get newer features from the test runner "sooner", which will help adoption of the tooling generally. |
I am happy to dedicate time to this where I'd be helpful, but I'm not actually sure if I the technical context for the native bits of the test suite as it exists now. |
See nodejs/node-core-test#54 for the upgrade, if you'd like to dedicate time, reviews would be nice ❤️ |
The
test
npm package serves as a backport of thenode:test
module for Node.js versions prior to v18. However, all these older versions are now end-of-life (EoL). This means the package offers no real advantage for users running supported (non-EoL) versions of Node.js, which they ideally should be using.Given that the package is outdated and no longer necessary, wouldn't it make sense to deprecate it?
CC @nodejs/test_runner
The text was updated successfully, but these errors were encountered: