Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distributors GitHub team? #59

Closed
Trott opened this issue Feb 5, 2018 · 39 comments
Closed

distributors GitHub team? #59

Trott opened this issue Feb 5, 2018 · 39 comments

Comments

@Trott
Copy link
Member

Trott commented Feb 5, 2018

From a comment from @kapouer:

i did not find any team of "distributors": debian, fedora, etc... maybe it would be a good idea to create one. (and i did not find where to open an issue about that fact).

Is there already one? If not, should there be one? I believe @nodejs/build has talked about this at least once but I don't know what the outcome was.

@nodejs/tsc @nodejs/community-committee

@mhdawson
Copy link
Member

mhdawson commented Feb 5, 2018

We had a similar discussion around "bundlers" like electron but I don't think we came to a final resolution in that discussion.

@gibfahn
Copy link
Member

gibfahn commented Feb 6, 2018

+1 on having one, I have felt the need to ping this group in the past, and I assume others have too. IDK what the naming should be, having electron and distro people in seems logical.

If someone wants to PR the team into the Contributing Extras section, then let's create the team.

@ljharb
Copy link
Member

ljharb commented Feb 6, 2018

Would version managers be considered a distributor?

@Trott
Copy link
Member Author

Trott commented Feb 6, 2018

Would version managers be considered a distributor?

Probably makes sense to start with a broad group where version managers would be included. Then, if experience indicates that something more granular is needed, we can split them into subteams at a later date.

@ljharb
Copy link
Member

ljharb commented Feb 6, 2018

Makes sense. I'm just not sure what definition of a "distributor" wouldn't apply to version managers, although the reverse is not necessarily true.

@mhdawson
Copy link
Member

mhdawson commented Feb 6, 2018

I'll volunteer to PR into the Contributing Extras section, unless somebody else wants to do it.

@gibfahn
Copy link
Member

gibfahn commented Feb 7, 2018

Makes sense. I'm just not sure what definition of a "distributor" wouldn't apply to version managers, although the reverse is not necessarily true.

The original list seems to be mostly people who do their own builds of node (electron + Linux distros), so might not be relevant to package managers. Agreed that in that case distributor is maybe not a great name.

No issue with anyone who wants to being involved in any case.

@mhdawson
Copy link
Member

mhdawson commented Feb 7, 2018

What do people think of "bundlers". Teams that either bundle node into their OS distributions or into their projects or products directly?

@ljharb
Copy link
Member

ljharb commented Feb 7, 2018

That term wouldn’t include Debian, Fedora, etc, would it?

@mcollina
Copy link
Member

mcollina commented Feb 7, 2018

Would that include docker image builders?

@mhdawson
Copy link
Member

mhdawson commented Feb 8, 2018

@ljharb it depends on how you define "bundlers" I tried to include them in my definition above but maybe it needs to be more explicit. How about:

Bundlers:
Teams that bundle node in some form (community binaries, custom built binaries, or source code) into their OS distributions, projects or products.

@mhdawson
Copy link
Member

mhdawson commented Feb 8, 2018

@mcollina I think it would include docker images builders.

@ljharb
Copy link
Member

ljharb commented Feb 8, 2018

Right, but Debian etc don’t bundle node - they bundle a package manager that can install node, but that’s not the same thing.

@mhdawson
Copy link
Member

mhdawson commented Feb 8, 2018

Maybe we can call the group "bundlers and installers":
Members do one of the following:

  • bundle node in some form (community binaries, custom built binaries, or source code) into their OS distributions, projects or products or
  • build installers that allow the installation of Node.js binaries

@ljharb
Copy link
Member

ljharb commented Feb 9, 2018

That then would also include all version managers?

@Elexy
Copy link

Elexy commented Feb 9, 2018

I am involved in https://github.com/nearform/nodejs-distribution, just curious if I could be of value in such a group.
What would the group be responsible for?
What are the goals / deliverables?
Again, just curious :-)

@mhdawson
Copy link
Member

mhdawson commented Feb 9, 2018

@ljharb I think so.

@Elexy we are just talking about setting up a github "team" were we can add people that would like to be notified through @nodejs/bundlersandinstallers or something like that when we have discussions/news that might impact them.

@bnb
Copy link
Contributor

bnb commented Feb 13, 2018

FWIW: @chrislea has some pretty institutional knowledge of Node.js distributions for Debian and RHEL, having built the images available at https://github.com/nodesource/distributions for several years now. I won't raise his hand for him, but he may be interested in participating as well ❤️

@chrislea
Copy link

NodeSource already makes installers / packages for the most popular distros, and we're revamping making Docker bits as well right now. So I'm not sure if the goals here are something different than that, but there's already been a fair amount of work done.

Happy to help out with whatever I can though, just let me know what I can do.

@mhdawson
Copy link
Member

@chrislea this is not about starting an effort to do something new, only to have a team we can include in discussions that might come up.

@mhdawson
Copy link
Member

@ljharb you ok with my last description of what members the team will cover? If so I'll try to think of a better name and then open a PR to add.

@ljharb
Copy link
Member

ljharb commented Feb 15, 2018

Yes. If so, please make the version manager working group team a child team of the larger team you intend to create :-)

@mhdawson
Copy link
Member

mhdawson commented Mar 2, 2018

PR to addnew team nodejs/node#19098

@mhdawson
Copy link
Member

mhdawson commented Mar 5, 2018

Landed new team name in nodejs/node#19098 as delivery-channels

@mhdawson
Copy link
Member

mhdawson commented Mar 5, 2018

https://github.com/orgs/nodejs/teams/version-management is now a child of the new team https://github.com/orgs/nodejs/teams/delivery-channels

@mhdawson
Copy link
Member

mhdawson commented Mar 5, 2018

@Trott did you have any contacts from the distributions that we should be adding to start off?

@ljharb
Copy link
Member

ljharb commented Mar 5, 2018

@mhdawson hm, it doesn't seem like version-management is a child of delivery-channels yet

@Trott
Copy link
Member Author

Trott commented Mar 6, 2018

@Trott did you have any contacts from the distributions that we should be adding to start off?

@mhdawson I know @kapouer expressed interest.

@Trott
Copy link
Member Author

Trott commented Mar 6, 2018

@mhdawson hm, it doesn't seem like version-management is a child of delivery-channels yet

@ljharb I've made it so, just now.

@kapouer
Copy link

kapouer commented Mar 6, 2018

Interest confirmed. For fedora i don't know who is involved. Maybe @sgallagher knows.

@Trott
Copy link
Member Author

Trott commented Mar 6, 2018

(Added @kapouer.)

@rogerwang
Copy link
Member

Please add me and @GnorTech. They are maintainers of NW.js which is a large downstream of Node.

@Elexy
Copy link

Elexy commented Mar 6, 2018

Confirming my interest since I am responsible for building nearForm's Node.js images for Docker hub and the Red Hat Catalog.

@sgallagher
Copy link

For Fedora, I'm probably the primary contact. However, you could also add [email protected] which is a mailing list that includes all the people involved in packaging Node.js and NPM modules in Fedora.

@ljharb
Copy link
Member

ljharb commented Mar 6, 2018

@sgallagher i believe it’s limited to Github accounts; it’s a team, not a mailing list.

@mhdawson
Copy link
Member

mhdawson commented Mar 6, 2018

@Trott I was pretty sure I had added it as a child, was it obvious what I had done wrong? I went to the version-management team and made the parent the new team. Did I just manage not to save that or was there some other step I need to do?

@Trott
Copy link
Member Author

Trott commented Mar 6, 2018

was it obvious what I had done wrong?

Nope.

Did I just manage not to save... ?

Probably. I've done that once or twice.

@Trott
Copy link
Member Author

Trott commented Mar 6, 2018

@mhdawson If it's OK with you, I'll leave it to you to add the additional people mentioned in this thread if you deem it appropriate. I feel like you are likely to have more direct involvement than me so that seems to make sense.

(Just making sure you're not assuming I'm handling it.)

@mhdawson
Copy link
Member

mhdawson commented Mar 7, 2018

@Trott ack. I belive I've added everybody who's expressed interest so far.

@Trott Trott closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests