-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distributors GitHub team? #59
Comments
We had a similar discussion around "bundlers" like electron but I don't think we came to a final resolution in that discussion. |
+1 on having one, I have felt the need to ping this group in the past, and I assume others have too. IDK what the naming should be, having electron and distro people in seems logical. If someone wants to PR the team into the Contributing Extras section, then let's create the team. |
Would version managers be considered a distributor? |
Probably makes sense to start with a broad group where version managers would be included. Then, if experience indicates that something more granular is needed, we can split them into subteams at a later date. |
Makes sense. I'm just not sure what definition of a "distributor" wouldn't apply to version managers, although the reverse is not necessarily true. |
I'll volunteer to PR into the Contributing Extras section, unless somebody else wants to do it. |
The original list seems to be mostly people who do their own builds of node (electron + Linux distros), so might not be relevant to package managers. Agreed that in that case distributor is maybe not a great name. No issue with anyone who wants to being involved in any case. |
What do people think of "bundlers". Teams that either bundle node into their OS distributions or into their projects or products directly? |
That term wouldn’t include Debian, Fedora, etc, would it? |
Would that include docker image builders? |
@ljharb it depends on how you define "bundlers" I tried to include them in my definition above but maybe it needs to be more explicit. How about: Bundlers: |
@mcollina I think it would include docker images builders. |
Right, but Debian etc don’t bundle node - they bundle a package manager that can install node, but that’s not the same thing. |
Maybe we can call the group "bundlers and installers":
|
That then would also include all version managers? |
I am involved in https://github.com/nearform/nodejs-distribution, just curious if I could be of value in such a group. |
FWIW: @chrislea has some pretty institutional knowledge of Node.js distributions for Debian and RHEL, having built the images available at https://github.com/nodesource/distributions for several years now. I won't raise his hand for him, but he may be interested in participating as well ❤️ |
NodeSource already makes installers / packages for the most popular distros, and we're revamping making Docker bits as well right now. So I'm not sure if the goals here are something different than that, but there's already been a fair amount of work done. Happy to help out with whatever I can though, just let me know what I can do. |
@chrislea this is not about starting an effort to do something new, only to have a team we can include in discussions that might come up. |
@ljharb you ok with my last description of what members the team will cover? If so I'll try to think of a better name and then open a PR to add. |
Yes. If so, please make the version manager working group team a child team of the larger team you intend to create :-) |
PR to addnew team nodejs/node#19098 |
Landed new team name in nodejs/node#19098 as delivery-channels |
https://github.com/orgs/nodejs/teams/version-management is now a child of the new team https://github.com/orgs/nodejs/teams/delivery-channels |
@Trott did you have any contacts from the distributions that we should be adding to start off? |
@mhdawson hm, it doesn't seem like version-management is a child of delivery-channels yet |
Interest confirmed. For fedora i don't know who is involved. Maybe @sgallagher knows. |
(Added @kapouer.) |
Please add me and @GnorTech. They are maintainers of NW.js which is a large downstream of Node. |
Confirming my interest since I am responsible for building nearForm's Node.js images for Docker hub and the Red Hat Catalog. |
For Fedora, I'm probably the primary contact. However, you could also add |
@sgallagher i believe it’s limited to Github accounts; it’s a team, not a mailing list. |
@Trott I was pretty sure I had added it as a child, was it obvious what I had done wrong? I went to the version-management team and made the parent the new team. Did I just manage not to save that or was there some other step I need to do? |
Nope.
Probably. I've done that once or twice. |
@mhdawson If it's OK with you, I'll leave it to you to add the additional people mentioned in this thread if you deem it appropriate. I feel like you are likely to have more direct involvement than me so that seems to make sense. (Just making sure you're not assuming I'm handling it.) |
@Trott ack. I belive I've added everybody who's expressed interest so far. |
From a comment from @kapouer:
Is there already one? If not, should there be one? I believe @nodejs/build has talked about this at least once but I don't know what the outcome was.
@nodejs/tsc @nodejs/community-committee
The text was updated successfully, but these errors were encountered: