Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Google account access #389

Closed
Fishrock123 opened this issue Jul 17, 2019 · 34 comments
Closed

Audit Google account access #389

Fishrock123 opened this issue Jul 17, 2019 · 34 comments

Comments

@Fishrock123
Copy link
Contributor

I dunno if anyone's kept up exactly but, a lot of people have access to the google account, which hosts the youtube, etc.

We should audit who still need access because there must be upwards of 30 or so people by now, which could pose a liability.

@keywordnew
Copy link
Contributor

Totally!

Is there a single source of truth for Google access records? I know that, at least for Zoom accounts, we don't have that. Brian has been starting to systematize that with some shared LastPass vaults.

@mhdawson
Copy link
Member

If it's just the Google Youtube account then through the UI you can see the list of people who have access.

@Fishrock123
Copy link
Contributor Author

Fishrock123 commented Jul 24, 2019

Ok so, here's the list(s) by role, updated as of 26/07/2019:

"Primary Owner"

Name GitHub Why
Brian Warner ? LF

Owner

Name GitHub Why
Adam Miller amiller-gh CC
Amanda Ennis OfficialLinuxAmanda (?) LF (?)
James Snell jasnell TSC
Jeremiah Senkpiel Fishrock123 TSC
Michael Dawson mhdawson TSC
Rachel Romoff RRomoff (?) LF / CC
Rich Trott trott TSC
Rod Vagg rvagg Build WG ?, Former TSC
Tracy Hinds hackygolucky CC

Manager

Name GitHub Why
Ahmad Bamieh bamieh CC
Ahmad Nassri ahmadnassri User-Feedback
Ann Marie Tonog AnnMarieTonog (?) LF Contractor
Bethany Griggs BethGriggs Release WG
Christopher Hiller boneskull Tooling group
Colin Ihrig cjihrig TSC
Dan Shaw dshaw User-Feedback
Daniel Bevenius danbev TSC
Eldar Djafarov edjafarov (?) ?
Franziska Hinkelmann fhinkel TSC
Gabriel Schulhof gabrielschulhof TSC
Gireesh Punam gireeshpunathil TSC
Johan Bergström jbergstroem Build WG
Josh Gavant joshgav Former TSC
Lara Taback --- ?
Matteo Collina mcollina TSC
Mike Kaufman mike-kaufman Diagnostics WG
Myles Borins MylesBorins TSC
Peter Marton hekike Diagnostics WG
Sam Roberts sam-github TSC
Tierney Cyren bnb CC
Timothy Arthur timzing (?) ?
Todd Benzies tbenzies LF
Tracy Lee ladyleet LF Contractor / CC
Uttam C Pawar uttampawar Benchmarking WG
William Kapke williamkapke CC

Removed

Name GitHub Role Why
Alexis Campailla orangemocha Manager Former TSC
Chris Dickinson chrisdickinson Manager Former TSC
Patrick Mueller pmuellr Manager Former Diag WG
Sarah Conway SarahKConway Manager LF ?
[email protected] --- Manager Looks deactivated
[email protected] gabrielschulhof Manager Invite ---

@Fishrock123
Copy link
Contributor Author

Fishrock123 commented Jul 24, 2019

I might not have gotten everything correct there so please feel free to edit it (but update the date if you do).

I think we can start some clean-up by:

  • Removing the deactivated account
  • Clearing Gabriel's apparent second invite
  • Removing access from anyone who was "former ..." and is no longer active.
  • Removing access from anyone we can't identify, if anyone falls into that category

@richardlau
Copy link
Member

Ok so, here's the list(s) by role, as of 24/07/2019:

Manager

Name GitHub Why
Bethany Griggs BethGriggs ?

@BethGriggs runs the Release WG meetings.

@Fishrock123
Copy link
Contributor Author

cc @nodejs/tsc @nodejs/community-committee

@cjihrig
Copy link

cjihrig commented Jul 25, 2019

uttampawar uses the access for Benchmarking WG meetings.

+1 to removing all of the "former"s and the deactivated account. Maybe ping anyone with a ? after a few more days before removing them.

@Trott
Copy link
Member

Trott commented Jul 25, 2019

I think @boneskull uses it for the Tooling meetings but I could be wrong.

@WaleedAshraf
Copy link
Contributor

Rachel Romoff is from LF and participates in most of CommComm meetings.
Tracy Lee is from thisdot and also participates in CommComm meetings.

I'm not sure which meetings they host.

@boneskull
Copy link

yep I use it for tooling group meetings

@mcollina
Copy link
Member

+1 to removing all of the "former"s and the deactivated account. Maybe ping anyone with a ? after a few more days before removing them.

Same! +1.

@mhdawson
Copy link
Member

Update a few based on what I know.

+1 to

+1 to removing all of the "former"s and the deactivated account. Maybe ping anyone with a ? after a few more days before removing them.

@Fishrock123
Copy link
Contributor Author

Ok I removed the following people:

Name GitHub Why
Alexis Campailla orangemocha Former TSC
Chris Dickinson chrisdickinson Former TSC
Patrick Mueller pmuellr Former Diag WG
[email protected] --- Looks deactivated
[email protected] Manager Invite ---

@Fishrock123
Copy link
Contributor Author

Does anyone know if these people presently need access?

Name GitHub Why
Eldar Djafarov edjafarov (?) ?
Lara Taback --- ?
Sarah Conway SarahKConway LF ?
Timothy Arthur timzing (?) ?
Todd Benzies tbenzies LF

@RRomoff
Copy link

RRomoff commented Jul 26, 2019

You can keep Todd Benzies and delete Sarah Conway. Thank you!

@Fishrock123
Copy link
Contributor Author

Fishrock123 commented Jul 26, 2019

Ok, did that.

@Fishrock123
Copy link
Contributor Author

Neither Eldar Djafarov or Timothy Arthur appear to be members of the Node.js github org, so I plan to also remove them. Should we let them know somehow?

Ditto for Lara Taback but also I can't find her github / any way to contact her. (The interface does not expose google email addresses, unfortunately.)

@mhdawson
Copy link
Member

I think Laura used to work at the Foundation, but I don't think I've talked to her in quite a while. I think removing should be ok.

@bnb
Copy link
Contributor

bnb commented Apr 28, 2020

Is there any further steps here? If so, what are they? If not, can we close this?

@Fishrock123
Copy link
Contributor Author

This kind of audit should be done yearly at least, imo.

I can be removed from the google account now too.

@Trott
Copy link
Member

Trott commented Apr 30, 2020

This kind of audit should be done yearly at least, imo.

It will probably be forgotten unless it is made someone's responsibility. "An audit will happen yearly" means it probably won't happen. "The CommComm Chair will perform an audit or identify someone to perform an audit in June of every year" is more likely to actually happen.

The question is: Who is the best person or people to take on this duty? Foundation folks? CommComm? TSC? Someone else?

@Trott
Copy link
Member

Trott commented Apr 30, 2020

Applied TSC and CommComm agenda labels but they can of course be removed if some resolution happens in the tracker. The question I'm hoping to get an answer to is in my comment above and reproduced here:

This kind of audit should be done yearly at least, imo.

It will probably be forgotten unless it is made someone's responsibility. "An audit will happen yearly" means it probably won't happen. "The CommComm Chair will perform an audit or identify someone to perform an audit in June of every year" is more likely to actually happen.

The question is: Who is the best person or people to take on this duty? Foundation folks? CommComm? TSC? Someone else?

@mhdawson
Copy link
Member

mhdawson commented May 4, 2020

I think adding it to the list of things for either the CommComm or TSC chair makes sense. I think it should be up to whoever we choose, to ensure it happens either by finding a volunteer or doing it themselves.

@mhdawson
Copy link
Member

mhdawson commented May 7, 2020

@brianwarner volunteered to take this on if we want the foundation to take this on.

@mhdawson
Copy link
Member

mhdawson commented May 7, 2020

@nodejs/community-committee are you ok with @brianwarner/foundation handling this?

@brianwarner
Copy link
Contributor

Proposed process from the TSC meeting:

  • Brian to generate a list of people with access
  • Brian to work with chairs of TSC and CommComm to do initial filtering of who should be on the list
  • Any names not tagged in the first round will be distributed to the broader TSC and CommComm for consideration
  • Any names not tagged in either round will be pruned from the account.

@mhdawson
Copy link
Member

mhdawson commented May 8, 2020

+1 to the suggested process.

@mhdawson
Copy link
Member

Generated list of people to be removed, confirmed with Tierney and did the removal. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests