-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semver-Minor commits in v4.x-staging #120
Comments
As a note, while I was reviewing commits today I opted to land a handful of semver minor commits into v4.x-staging that had not yet been voted on by the CTC or WG that seemed like decent candidates for the |
The V8 test runner changes can be semver-patch. I'm okay with landing the node::FreeEnvironment() change. I'd be in favor (as opposed to just okay) if I knew there would be actual users. Electron doesn't use v4.x. |
In today's LTS WG meeting we discussed all commits on the list. There was consensus that all of the commits mentioned in the post are appropriate for LTS and should be landed in v4.5.0. I am closing this issue but please feel free to continue the conversation if you have any questions or concerns |
Agreed upon
Buffer Api
b4a279155a
] - (SEMVER-MINOR) buffer: backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562ee2f08fe51
] - (SEMVER-MINOR) buffer: ignore negative allocation lengths (Anna Henningsen) #7562Buffer Zero Fill Backport:
a27eeab6a5
] - (SEMVER-MINOR) buffer: backport --zero-fill-buffers cli option (James M Snell) #5745intel v-tune profiling:
cc8ec23ad5
] - (SEMVER-MINOR) build,src: add Intel Vtune profiling support (Chunyang Dai) #5527V8 test runner:
c6fab003b6
] - (SEMVER-MINOR) deps: backport 9c927d0f01 from V8 upstream (Myles Borins) #74515f9110e231
] - (SEMVER-MINOR) test: run v8 tests from node tree (Bryon Leung) #4704V8 post mortem data:
7652f559bd
] - (SEMVER-MINOR) deps: cherry-pick 68e89fb from v8's upstream (Fedor Indutny) #3779Not Agree Upon
Repl tab copy fix:
1aa9c318c9
] - (SEMVER-MINOR) repl: copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958Fix Linking for shared library:
2e4fb99a86
] - (SEMVER-MINOR) src: add node::FreeEnvironment public API (Cheng Zhao) #3098The text was updated successfully, but these errors were encountered: