Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no protocol specified, fallback to req.protocol, not to https:// #42

Closed
rubenstolk opened this issue Jun 18, 2014 · 1 comment
Closed

Comments

@rubenstolk
Copy link
Contributor

If I only specify a path property and not the callbackUrl, I would expect the protocol to fallback to whatever is used in the request, not https.

For example, when I have my server running on http://localhost:4000 and I specify only the property 'path' to be /callback, I would expect the callbackUrl to be http://localhost:4000/callback, currently it will be https://localhost:4000/callback.

@ploer
Copy link
Contributor

ploer commented Jun 18, 2014

Yup, that makes sense to me. Care to put together a pull request?

@ploer ploer closed this as completed in c928fdc Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants