Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for multiple valid certificates or dynamic certificates #236

Closed
richjharris opened this issue Sep 27, 2017 · 1 comment
Closed

Comments

@richjharris
Copy link
Contributor

In our organisation we roll the signing certificate for our ADFS servers every year. During the roll over period the server provides two certificates which may be valid, so when a SAML response is provided it is valid if it is signed with either of those signatures.

passport-saml has two issues handling this scenario:

  1. It only handles one valid certificate which is used to check if a signature is valid. When a new certificate is issued it may be valid for a SAML response to be signed with either a new or old certificate.

  2. It doesn't provide a mechanism to update the cert used to validate the signature in a SAML response. If the certificate used is dynamic and our service can fetch the new certificate there isn't a way update the certificate used.

I made a PR here #218 to address these issues a while ago but it hasn't received any traction.

@markstos
Copy link
Contributor

markstos commented Jan 3, 2018

PR #218 was merged. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants