Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested signatures in SAML responses causes only inner to be verified #168

Closed
timotm opened this issue Sep 12, 2016 · 2 comments
Closed

Nested signatures in SAML responses causes only inner to be verified #168

timotm opened this issue Sep 12, 2016 · 2 comments

Comments

@timotm
Copy link

timotm commented Sep 12, 2016

If SAML response contains more than one signature, e.g. one for the top level and one for an assertion, only the inner signature is currently verified. This sort of undermines the point of validation as outside the assertion, the response could have been altered and it goes unnoticed.

Some example responses with nested signatures can be found in this PDF http://www.valtori.fi/download/noname/%7B1BD49CD9-102D-4DBA-AE89-4E76AACE7C4F%7D/12955

@pdspicer
Copy link
Contributor

They are actually both checked, but failure only occurs NO signatures are validated. Additionally if the outer signature is valid then the inner signature is the one that is not checked (this case just assumes the inheritance of signature correctness). Definitely agree that failure to validate an outer signature (if one is present) should be an error.

@markstos
Copy link
Contributor

markstos commented Oct 2, 2018

I'm merging this into #281, which has more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants