fix: remove upper bound for node engine semver

[pimlie]

Resolves: #48

/cc @tinovyatkin

[codecov]

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          183       183           
  Branches        30        30           
=========================================
  Hits           183       183           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126b4ec...e694966. Read the comment docs.

[readeral]

Interesting node-fetch changed the engine requirements to be >=10.17.0 but with the linting issues, maybe the more specific version you've landed on is required by fetch-blob?

[tinovyatkin]

@pimlie What do you see as a downside of just >=10.17?

[tinovyatkin]

@xxczaki It's a serious bug, we will need to release a patch version after merging this (as it may preventing install of [email protected] via yarn on Node LTS)

[tinovyatkin]

I would love to see this in sync with current version of node-fetch - do you see any problem with versions 11.x to be included?

[tinovyatkin]

Suggested change

	"node": "^10.17.0 || >=12.3.0"
	"node": ">=10.17"

[pimlie]

This is what I added at first btw, but changed it due to the lint error. Not sure if v11 also supports it, I trusted the lint error to specify the correct minimum version

[xxczaki]

@tinovyatkin We will also need to release a new beta version of node-fetch with the updated fetch-blob dependency (maybe something like 3.0.0-beta.7-fixnodeversion), won't we?

[tinovyatkin]

@xxczaki No, node-fetch is fine, we have caret there, so, it will pick up 2.0.1 automatically. We should, however, deprecate 2.0.0 of fetch-blob

[pimlie]

@tinovyatkin See the first lint error, it said: The stream.Readable.from is not supported until Node.js 12.3.0 (backported: ^10.17.0).

[xxczaki]

cc @tinovyatkin @pimlie

Released [email protected] and deprecated [email protected].

[tinovyatkin]

@pimlie Thank you for your contribution!