-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sharded Llama export test also compile to IREE module and verify numerics #237
Merged
sogartar
merged 8 commits into
nod-ai:main
from
sogartar:compile-to-iree-module-in-sharded-llama-test
Oct 3, 2024
Merged
Make sharded Llama export test also compile to IREE module and verify numerics #237
sogartar
merged 8 commits into
nod-ai:main
from
sogartar:compile-to-iree-module-in-sharded-llama-test
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sogartar
changed the title
Make sharded Llama export test also compile to IREE module
WIP Make sharded Llama export test also compile to IREE module
Sep 27, 2024
This PR is waiting on iree-org/iree#18663. |
sogartar
changed the title
WIP Make sharded Llama export test also compile to IREE module
Make sharded Llama export test also compile to IREE module and verify numerics
Oct 3, 2024
IanNod
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nit comments but looks good to me
sogartar
force-pushed
the
compile-to-iree-module-in-sharded-llama-test
branch
from
October 3, 2024 18:14
2bd895c
to
975e46d
Compare
rsuderman
requested changes
Oct 3, 2024
rsuderman
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies the IREE module numerical accuracy compared to execution with PyTorch.
The prefill step result has very low absolute accuracy of around
1e-2
for FP32.The resulting cache state of prefill is way off.
The decode step accuracy is also completely off.
This test is market as skipped until iree-org/iree#18663 is merged. Without it the IREE compilation will crash.