Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility #11

Open
LuCeHe opened this issue Nov 1, 2023 · 0 comments
Open

Windows compatibility #11

LuCeHe opened this issue Nov 1, 2023 · 0 comments

Comments

@LuCeHe
Copy link

LuCeHe commented Nov 1, 2023

Hi, thanks a lot for your work! To make it more accessible, can you make it 100% compatible with Windows? Almost everywhere the paths are dealt correctly with os, but line 81 in create_hdf5.py does a label = int(file_d.split('/')[-2]) that does not work with Windows. If you use os.path.split it will work on any platform. Be careful also with statements like

digit_train = glob.glob(os.path.join(dataset_path, 'Train/{}/*.bin'.format(digit)))

I think it's safer to write it as

digit_train = glob.glob(os.path.join(dataset_path, 'Train', str(digit), '*.bin'))

I could add those changes if you give me permission, since I'm using your dataset for my research, and I'm on Windows.

Have a good day,
Luca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant