Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for multi area models #181

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix: for multi area models #181

merged 1 commit into from
Feb 22, 2024

Conversation

k-doering-NOAA
Copy link
Collaborator

Fleets only fish in 1 area, so this should work for all multiarea models. Thanks to @skylersagarese-NOAA for identifying this issue and fix!

@skylersagarese-NOAA, could you test and make sure this works for you? If it does, we can merge it into main.

Addresses #175

Fleets only fish in 1 area, so this should work for all multiarea models. Thanks to @skylersagarese-NOAA for identifying this issue and fix!
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ce13f34) 69.84% compared to head (dbb7ad0) 69.80%.

Files Patch % Lines
R/extendOM.R 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   69.84%   69.80%   -0.05%     
==========================================
  Files          21       21              
  Lines        4388     4392       +4     
==========================================
+ Hits         3065     3066       +1     
- Misses       1323     1326       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k-doering-NOAA k-doering-NOAA merged commit 6d552a4 into main Feb 22, 2024
12 checks passed
@k-doering-NOAA k-doering-NOAA deleted the debug-2-area branch February 22, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant