Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Docker support #68

Closed
jwmoss opened this issue Sep 14, 2021 · 4 comments
Closed

[ENHANCEMENT] Docker support #68

jwmoss opened this issue Sep 14, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jwmoss
Copy link

jwmoss commented Sep 14, 2021

Is your feature request related to a problem? Please describe.
I'm wanting to run this in a container using Docker. The problem is I do not know how to build from source. I've google'd my way through and couldn't find anything consistent.

Describe the solution you'd like
I'd love to see a sample Dockerfile that would allow me to run something like this locally.

Describe alternatives you've considered
I've run this locally with the npm commands shown in the readme successfully.

League ID
731604692018262016

Additional context
Add any other context or screenshots about the feature request here.

@jwmoss jwmoss added the enhancement New feature or request label Sep 14, 2021
@nmelhado
Copy link
Owner

I haven't Docker-ized it myself, but this loos like a decent guide: https://blog.alexanderwolf.tech/how-to-dockerize-your-sveltekit-app/

I'm using the Vercel adapter for ease of deployment (especially for inexperienced developers), but I'd imagine you'd want to change to adapter-node instead (if your goal is to deploy this independently). Here's some info on svelte kit adapters: https://kit.svelte.dev/docs#adapters

@nmelhado
Copy link
Owner

@jwmoss Did the above help?

@jwmoss
Copy link
Author

jwmoss commented Sep 18, 2021

@jwmoss Did the above help?

It did not. I tried a handful of different variations, but couldn't figure it out.

@nmelhado
Copy link
Owner

nmelhado commented Oct 7, 2021

Resolved in pr #84. Many thanks to @1600dolo

@nmelhado nmelhado closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants