Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 404 Error on Manager Profile Pages and Rivalry Page #244

Closed
ittwa opened this issue Aug 7, 2023 · 10 comments · Fixed by #250
Closed

[BUG] 404 Error on Manager Profile Pages and Rivalry Page #244

ittwa opened this issue Aug 7, 2023 · 10 comments · Fixed by #250
Assignees
Labels
bug Something isn't working

Comments

@ittwa
Copy link

ittwa commented Aug 7, 2023

Describe the bug
The 404 page ("Hut, Hut, Blue 404!") shows on the Rivalry page and on any individual manager page.

edit: this also shows on the Records page as well.

Your League ID
918205115247595520

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Managers page
  2. Click on any Manager
  3. See error

OR

  1. Go to the Rivalry page
  2. See error

Expected behavior
I expect to see the pages like you have on your site (Manager profile, Rivalry)

Screenshots
image

image

Desktop:

  • OS: macOS Monterey v 12.6
  • Browser: Brave
  • Version: 1.56.20 Chromium version 115.0.5790.171.

edit: I've also confirmed this is happening in Chrome as well.

Smartphone:

  • Device: iPhone 13
  • OS: iOS 16.6
  • Browser: Brave
  • Version: 1.52.1 (23.7.11.14)

Additional context
@nmelhado I'm sure this could just be an error/oversight on my part as setting up a website is all relatively foreign to me. I followed your instructions and everything is working on my site, except for the manager profile pages and rivalry pages. Here is my repo if it helps. Thanks!

@ittwa ittwa added the bug Something isn't working label Aug 7, 2023
@TannerHopkins
Copy link

TannerHopkins commented Aug 20, 2023

+1
Similar issue here, but weirdly only happening with one of my league sites - the only differences are the leagueInfo.js and badge.png files - otherwise all of the rest of the repository is exactly the same (confirmed this).

In my case, I get it when clicking on managers on the managers page, as well as when clicking on the "trades & waivers" page. Also, trades & waivers fail to load on the home page.

Both of these are new leagues, but the one that is having the issue happens to have been "reset" once within sleeper (long story), so I wonder if something related to that is causing the problem.

@TannerHopkins
Copy link

@ittwa - out of curiosity, has your league ever been reset?

@ittwa
Copy link
Author

ittwa commented Aug 20, 2023

Thanks for the additional context, @TannerHopkins. I don't believe my league has ever been reset, but it could have been like ~4 years ago when I was initially migrating from ESPN.

@nmelhado any chance you can look into this? I'm hoping to share this site with my league prior to the start of the regular season.

@TannerHopkins
Copy link

TannerHopkins commented Aug 20, 2023

Not the most technical here (at least with websites), but I used the chrome "inspect" feature and checked the console and found this exact error for both of my pages:
image

Specifically, error appears to be here (after clicking on leagueTransactions.0030b38d.js:1:2014):
image
(This corresponds to line 168 of src/lib/utils/helperFunctions/leagueTransactions.js)

Feel like this should help a little with the debugging.

If you want to look for yourself, here is my (failing) website: https://grandexchange.vercel.app/

@TannerHopkins
Copy link

I had another theory on something different about my league - we've had a couple of waiver force adds to teams, which shows up as a different type of transaction ("type":"commissioner"). That being said, it looks like this repo does not currently track "type":"free_agent" transactions either, so I'm doubtful that a different type of transaction than the current 2 that are being tracked (waiver and trade) would break anything - unless it doesn't like that the commissioner transactions are created by one user but impact another user's roster?
Just thinking out loud here 🤷🏻

@nmelhado nmelhado linked a pull request Aug 21, 2023 that will close this issue
@nmelhado
Copy link
Owner

Sorry for the delay all. I've been super busy and haven't had a chance to debug at all. Finally got around to it this morning. he bug was happening because somehow in both of your leagues there were some matchups with only 1 team. I've added a simple fix which should resolve your issues!

@nmelhado
Copy link
Owner

@TannerHopkins and @ittwa this is now fixed. If you're still seeing any issues after you update, please let me know!

@ittwa
Copy link
Author

ittwa commented Aug 22, 2023

Thanks, @nmelhado! Looks great!

@TannerHopkins
Copy link

Thanks so much @nmelhado ! No worries on the delay at all, appreciate all that you've done for creating this in the first place. Excited to see how my league likes it!

@sethtobrien
Copy link

Hello! I'm having a similar issue on this page.

Here is my code:
image

Here is my league page:
https://therealv3-sethtobrien.vercel.app/managers

Any help is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants