Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Option to use OwnerID instead of RosterID #164

Closed
mharrison0224 opened this issue Sep 22, 2022 · 3 comments · Fixed by #185
Closed

[ENHANCEMENT] Option to use OwnerID instead of RosterID #164

mharrison0224 opened this issue Sep 22, 2022 · 3 comments · Fixed by #185
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mharrison0224
Copy link

Is your feature request related to a problem? Please describe.
In redraft there is too much turnover, stats per "rosterID" do not translate well.

Describe the solution you'd like
Switch to OwnerID over RosterID when linking data to teams/managers.

Describe alternatives you've considered
Continue to use RosterID, but allow for instead a function to export previous league data into JSON files that we could edit to create fake rosterIDs like 99 to account for old teams no longer being ran by the same owner.

Additional context
I think by switching to OwnerID it also opens the potential to add more data in the future like (record against X manager). It also has the potential for us to add "previous managers" to our list of managers thus creating an even better reason to use this website vs just sleeperbot.

@mharrison0224 mharrison0224 added the enhancement New feature or request label Sep 22, 2022
@nmelhado nmelhado added the help wanted Extra attention is needed label Sep 24, 2022
@nmelhado
Copy link
Owner

This was requested a long time ago and is a very good suggestion that would really enhance the league records. I think this is one of the higher impact enhancements that could be implemented.

@nmelhado nmelhado removed their assignment Sep 24, 2022
@nmelhado
Copy link
Owner

I'll assign myself when I have the capacity to do this. If someone else wants to take this on in the meantime that would be great!

@nmelhado nmelhado self-assigned this Jan 8, 2023
@nmelhado
Copy link
Owner

nmelhado commented Jan 8, 2023

Underway!

This ended up being way more work than I expected, but I'm hoping to close it out in the next week or two.

@nmelhado nmelhado linked a pull request Jan 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants