Prefix CLOUDINARY ENVs, move to top-level config

[coolaj86]

Re:

card_app/routes/index.js

Line 9 in 314ac09

cloudinary.config({

API_KEY is rather generic. I'd recommend CLOUDINARY_API_KEY. Also, I'd recommend using global config up to the top level for 2 reasons:

1. Anything that requires process.env requires more documentation / education if it exists anywhere except the top-level app.js / server.js. Better to consolidate it.
2. If it's truly a singleton, and you can't configure it, then best to put it at a top-level scope rather than down in routes, unless it's a "mini app" or sub route which might have configuration of its own and act in standalone fashion too

Didn't quite articulate that perfectly, but you get the point I think.

[coolaj86]

Also, it looks like you're re-initializing the global config many times.