Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONFeedParser date parsing can cause unexpected behaviour #89

Closed
lauri-koli opened this issue May 28, 2019 · 1 comment · Fixed by #96
Closed

JSONFeedParser date parsing can cause unexpected behaviour #89

lauri-koli opened this issue May 28, 2019 · 1 comment · Fixed by #96

Comments

@lauri-koli
Copy link

The date formatter used in JSONEncoder's decodingStrategy does not have locale and timezone properties set to recommended values for fixed date representations. We encountered some fatal errors which were most likely caused by this.
@lauri-koli
Copy link
Author

The fatal error can be reproduced by setting the device to use 12-hour clock.

@lauri-koli lauri-koli mentioned this issue Aug 12, 2019
Merged
@nmdias nmdias closed this as completed in #96 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change JSONFeedParser date decoding strategy to RFC3339 lauri-koli/FeedKit
1 participant
@lauri-koli