-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation as ~/.config/direnv/lib/sorri.sh #2
Comments
Hehe yes indeed! I wrapped
That looks nice! I was really trying to keep it to one line though. I was thinking Bottom line: yes yes yes! |
Okay, good to know you're already on this. It sounds like we're not that far off, and it also sounds like you don't really need anything like a PR from me. So I'll just wait a little bit and see if it lands soon. I'm also fine if Direnv can set a variable and make the invocation site more streamlined. |
source_urlI'm going to make a new release of direnv today that includes this feature: direnv/direnv#562 Basically, it allows you to source files from the Internet. Eg: source_url "https://raw.githubusercontent.com/nmattia/sorri/bff9e44734b19d5c65534c9bfd10bdf3be90b623/sorri" "sha256-CMbjOcSXWtTqSW0jKBPWWPBMBiOvJsh2vnFJoQJ6yFM=" Right now, this doesn't seem to work with sorri as it outputs "OH NOO", but the mechanism is there and sorri just needs to be fixed/changed to support that. .envrc vs source_envDirenv sets A way to distinguish between the |
Ah, that's great timing! |
that feature is now available in direnv 2.23.0 |
I think I have a preference of installing a tool like
sorri
globally as a library. I think you're file is very close. I just need to crop out the last call tosorri_main
.So it's not like I'm blocked or anything, this is easy enough to do.
But if you think it's a good idea, I wonder if we can make it more of an official way to install
sorri
as a courtesy to new users.Would you be opposed to taking out the last call to
sorri_main
? And then just allowing the invocation to be done explicitly in the user's.envrc
file? On that note, "sorri_main" seems like a bit of an internal name. Could we just make it "sorri" instead?I think the instructions on the README would then be:
Is that too bad? Any suggested alternative?
The text was updated successfully, but these errors were encountered: