Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Name #646

Closed
SylvainCorlay opened this issue Jul 4, 2017 · 15 comments
Closed

Package Name #646

SylvainCorlay opened this issue Jul 4, 2017 · 15 comments
Labels
kind: question solution: proposed fix a fix for the issue has been proposed and waits for confirmation

Comments

@SylvainCorlay
Copy link

I am interested in making a package for the conda package manager (on conda-forge).

What would you like the name of the package to be?

The conan package name is jsonformoderncpp. The cmake project name is nlohmann_json.

@SylvainCorlay
Copy link
Author

Quick bikeshedding question as I have the occasion: have you guys considered splitting into multiple headers?

@nlohmann
Copy link
Owner

nlohmann commented Jul 4, 2017

I think nlohmann/json or so would be best as this is the name at Homebrew. Please have a look at the README for other package managers.

I do not plan to split the header for release, but we may split it for development.

@theodelrieu
Copy link
Contributor

We could also release the multiple headers version, and keeping the single header release of course.

I think it would be a great addition, I've already split some headers in my work to help with compile times.

@SylvainCorlay
Copy link
Author

What is the benefit of a single header?

@SylvainCorlay
Copy link
Author

Regarding the package name, the conda documentation specifies

Conda package names are normalized, and may contain only lowercase alpha characters, numeric digits, underscores, hyphens, or dots

so it could either be

nlohmann_json or nlohmann.json.

@nlohmann
Copy link
Owner

nlohmann commented Jul 4, 2017

The benefit is a trivial integration: just throw in one include and you're done.

About the name: I don't really have an opinion.

@SylvainCorlay
Copy link
Author

The benefit is a trivial integration: just throw in one include and you're done.

ok. Thanks. a 15k-long single header is a bit scary too :)

I really love your modern C++ API following the idioms of the STL (PS: I am co-author of xtensor)... I have been banging my head when trying to do anything with rapidjson, and despite the claim that it is much faster, I am seriously considering dropping it.

Regarding the packaging, let me know if you come up with an idea. I cannot get to it before a couple of days. It would make sense for it to have the same name on conda / debian and all.

@nlohmann
Copy link
Owner

nlohmann commented Jul 8, 2017

As the name is jsonformoderncpp for Conan, I think this should also be used for Conda.

@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Jul 8, 2017
@SylvainCorlay
Copy link
Author

Sounds good! I was just going to propose nljson for a shorter version of nlohmann_json . There also seems to be a conan package with this name https://github.com/arnemertz/conan-nlJson.

Also, since headers typically fall under PREFIX/include/, I would have done something like PREFIX/include/nljson/json.hpp, and the include statement in most client code would then be #include "nljson/json.jpp".

@nlohmann
Copy link
Owner

nlohmann commented Jul 8, 2017

@SylvainCorlay
Copy link
Author

I like short 😄

@SylvainCorlay
Copy link
Author

Btw, I am reading up your C++ standard proposal which looks great.

@nlohmann
Copy link
Owner

nlohmann commented Jul 8, 2017

It's 99.9% the work of @mariokonrad. I did not find the time to work on it so far. But yes, he does a tremendous job.

@nlohmann
Copy link
Owner

nlohmann commented Jul 9, 2017

Can I close this issue? If there is anything to be changed in the library to support Conda, please let me know (or, better, open a PR).

@SylvainCorlay
Copy link
Author

Sure. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: question solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Development

No branches or pull requests

3 participants