-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Name #646
Comments
Quick bikeshedding question as I have the occasion: have you guys considered splitting into multiple headers? |
I think I do not plan to split the header for release, but we may split it for development. |
We could also release the multiple headers version, and keeping the single header release of course. I think it would be a great addition, I've already split some headers in my work to help with compile times. |
What is the benefit of a single header? |
Regarding the package name, the conda documentation specifies Conda package names are normalized, and may contain only lowercase alpha characters, numeric digits, underscores, hyphens, or dots so it could either be
|
The benefit is a trivial integration: just throw in one include and you're done. About the name: I don't really have an opinion. |
ok. Thanks. a 15k-long single header is a bit scary too :) I really love your modern C++ API following the idioms of the STL (PS: I am co-author of xtensor)... I have been banging my head when trying to do anything with rapidjson, and despite the claim that it is much faster, I am seriously considering dropping it. Regarding the packaging, let me know if you come up with an idea. I cannot get to it before a couple of days. It would make sense for it to have the same name on conda / debian and all. |
As the name is |
Sounds good! I was just going to propose Also, since headers typically fall under |
There is also https://github.com/vthiery/conan-jsonformoderncpp. |
I like short 😄 |
Btw, I am reading up your C++ standard proposal which looks great. |
It's 99.9% the work of @mariokonrad. I did not find the time to work on it so far. But yes, he does a tremendous job. |
Can I close this issue? If there is anything to be changed in the library to support Conda, please let me know (or, better, open a PR). |
Sure. closing. |
I am interested in making a package for the conda package manager (on conda-forge).
What would you like the name of the package to be?
The conan package name is
jsonformoderncpp
. The cmake project name isnlohmann_json
.The text was updated successfully, but these errors were encountered: