Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider listing files explicitly instead of using GLOB #1686

Closed
ghost opened this issue Jul 23, 2019 · 1 comment · Fixed by #1779
Closed

Consider listing files explicitly instead of using GLOB #1686

ghost opened this issue Jul 23, 2019 · 1 comment · Fixed by #1779

Comments

@ghost
Copy link

ghost commented Jul 23, 2019

From the docs:

Note: We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate. The CONFIGURE_DEPENDS flag may not work reliably on all generators, or if a new generator is added in the future that cannot support it, projects using it will be stuck. Even if CONFIGURE_DEPENDS works reliably, there is still a cost to perform the check on every rebuild.

The only small downside is that developers will have to remember to add any new files to the sources/headers list.

@stale
Copy link

stale bot commented Aug 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Aug 27, 2019
@nlohmann nlohmann added pinned and removed state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated labels Aug 27, 2019
@nlohmann nlohmann self-assigned this Oct 9, 2019
@nlohmann nlohmann added this to the Release 3.7.1 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment