Missing v3.6.1 tag on master branch

[robertoleksy]

Found by [email protected]

[nlohmann]

You're right. Can you give me a hint how to set it after the fact?

[MartB]

Switch to master and issue the following:

git tag v3.6.1 1126c9c 
git push origin v3.6.1

[nlohmann]

This does not work unfortunately:

$ git tag v3.6.1 1126c9c

fatal: tag 'v3.6.1' already exists

$ git push origin v3.6.1

Everything up-to-date

[MartB]

Edit nvm im wrong here, tags are bound to commits not to branches so it shouldnt matter.

You can close this issue as invalid then, if master doesnt differ from develop

[nlohmann]

Alright. Thanks for reporting anyway!

[MartB]

Okay actually, your master branch differs from the develop branch which is not really a great idea, the tag points to a commit which is only available in the develop branch.

[nlohmann]

I am using the same release script for a year now, so I am confused that tags behave differently now.

[MartB]

This is not specific to 3.6.1 a few more i checked are also only in develop.

It entirely depends on how you want to tag, if you want the master branch to be used as a way for users to build releases based on tags, the current tagging wont work and one must use develop for it.

If you want the master branch to have the same tags, you need to tag a commit that is in both branches.

You can clearly see why they are not the same atm:
https://github.com/nlohmann/json/compare/master

all the release merge commits are missing on master.