-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: replace alternative tokens for !, && and || with their symbols #1652
Comments
Thanks for suggesting, but I like this. Why does it bother you how the library‘s internal logic is expressed? |
When compiling using the latest release from the master branch today, clang 7 threw about 90 compiler errors at me which weren't understandable at all. Turns out replacing the alternative tokens with the symbols fixed the problem. |
Sounds like either a compiler bug or something in your environment is doing something illegal with the preprocessor. These are reserved words in C++ and can't be redefined. Do you have a small sample program that shows the errors? |
It really sounds like a bug. We use Clang 7 in our CI via Travis, and also include |
I don't know what caused it. If this issue is only present in my setup it's fine to leave it like this (I just ran a simple find-replace on the include to fix it for myself). |
I'm closing this as it is unrelated to the library. Feel free to check back if you found the reason why your compiler complained about the operators. |
Title explains the issue. The usage of
and
,or
, andnot
instead of&&
,||
and!
has caused more compiler errors and headscratching for me than it adds to the readability of the code.The text was updated successfully, but these errors were encountered: