Added "ValuesOnly" property to Cookie and QueryString layout renderers + support for multivalue cookie keys in ASP.NET core #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…derer, AspNetRequestCookieLayoutRenderer - adds ValuesOnly property and tests, plus fixes multi-value test bugs in the latter
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=====================================
+ Coverage 59% 59% +1%
=====================================
Files 31 31
Lines 396 401 +5
Branches 88 91 +3
=====================================
+ Hits 232 237 +5
Misses 129 129
Partials 35 35
Continue to review full report at Codecov.
|
|
Thanks! |
|
@304NotModified By the way, happy to update wiki for this and also my assembly version work. |
304NotModified
changed the title
304NotModified
approved these changes
Aug 1, 2018
304NotModified
changed the title
Please do, you could add: added in NLog.Web / NLog.Web.AspNetCore 4.6 :) |
|
Looks good! Thanks! We will release this after NLog 4.5.8 is released :) |
snakefoot
added
ASP.NET Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294 by adding a ValuesOnly property to AspNetLayoutMultiValueRendererBase and implements it for sub-classes AspNetRequestCookieLayoutRenderer and AspNetRequestQueryStringLayoutRenderer. This also includes a fix for multi-value cookie unit tests that slipped through my previous PR, and simplifies Core vs Full framework implementation and unit tests.
Also fixes unit tests not functioning correctly for full framework AssemblyVersionLayoutRender due to incorrect project references.