-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved registration of hidden assemblies for callsite handling #272
Conversation
…LL has been loaded (Fix obsolete messages)
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
======================================
+ Coverage 57% 57% +<1%
======================================
Files 31 31
Lines 407 407
Branches 92 92
======================================
+ Hits 231 233 +2
Misses 138 138
+ Partials 38 36 -2
Continue to review full report at Codecov.
|
@304NotModified Have updated to NLog.Extensions.Logging ver. 1.0.1, and adjusted the code accordingly. |
@@ -5,7 +5,7 @@ | |||
|
|||
<TargetFrameworks>netstandard1.5;net451;net461;netstandard2.0</TargetFrameworks> | |||
|
|||
<VersionPrefix>4.5.1</VersionPrefix> | |||
<VersionPrefix>4.5.2</VersionPrefix> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the release notes (and maybe also the changelog) when updating the version (cannot be done afterwards anymore :(. )
Or leave the version unchanged, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted change
…Log.Extensions.Logging
Thanks! |
NLog.Extensions.Logging ver. 1.0.1 now handles everything in its NLogLoggerProvider.
And also corrected obsolete notifications for ConfigureNLog to match the Wiki