Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved registration of hidden assemblies for callsite handling #272

Merged
merged 3 commits into from
Apr 7, 2018

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Apr 6, 2018

NLog.Extensions.Logging ver. 1.0.1 now handles everything in its NLogLoggerProvider.

And also corrected obsolete notifications for ConfigureNLog to match the Wiki

@snakefoot snakefoot changed the title Corrected obsolete notifications to match the Wiki Corrected obsolete notifications for ConfigureNLog to match the Wiki Apr 6, 2018
@codecov
Copy link

codecov bot commented Apr 6, 2018

Codecov Report

Merging #272 into master will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #272    +/-   ##
======================================
+ Coverage      57%    57%   +<1%     
======================================
  Files          31     31            
  Lines         407    407            
  Branches       92     92            
======================================
+ Hits          231    233     +2     
  Misses        138    138            
+ Partials       38     36     -2
Impacted Files Coverage Δ
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 98% <0%> (+2%) ⬆️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 84% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe3a15...6e82cd5. Read the comment docs.

@snakefoot snakefoot changed the title Corrected obsolete notifications for ConfigureNLog to match the Wiki Removed explicit registration of hidden assemblies for callsite handling Apr 7, 2018
@snakefoot
Copy link
Contributor Author

@304NotModified Have updated to NLog.Extensions.Logging ver. 1.0.1, and adjusted the code accordingly.

@@ -5,7 +5,7 @@

<TargetFrameworks>netstandard1.5;net451;net461;netstandard2.0</TargetFrameworks>

<VersionPrefix>4.5.1</VersionPrefix>
<VersionPrefix>4.5.2</VersionPrefix>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the release notes (and maybe also the changelog) when updating the version (cannot be done afterwards anymore :(. )
Or leave the version unchanged, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted change

@304NotModified 304NotModified merged commit 52aeec9 into NLog:master Apr 7, 2018
@304NotModified
Copy link
Member

Thanks!

@304NotModified 304NotModified changed the title Removed explicit registration of hidden assemblies for callsite handling Improve registration of hidden assemblies for callsite handling Apr 12, 2018
@304NotModified 304NotModified changed the title Improve registration of hidden assemblies for callsite handling Improved registration of hidden assemblies for callsite handling Apr 12, 2018
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 2 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET Core ASP.NET Core - all versions enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants