Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies #232

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Updated dependencies #232

merged 1 commit into from
Dec 5, 2017

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Dec 4, 2017

fixes #228, fixes #230

@snakefoot
Copy link
Contributor

snakefoot commented Dec 4, 2017

  • netstandard1.3 should be removed (along with the dependency Microsoft.Extensions.PlatformAbstractions)
  • net461 dependes on asp.core.net.v2, but in the test-project then it now depends on asp.core.net.v1
  • Think net461 still need dependency on System.ValueTuple

@304NotModified
Copy link
Member Author

Microsoft.Extensions.PlatformAbstractions not needed for .NET standard 1.5?

@snakefoot
Copy link
Contributor

Microsoft.Extensions.PlatformAbstractions not needed for .NET standard 1.5?

Nope it was only included for netstandard1.3

@304NotModified
Copy link
Member Author

ok thx! :)

@snakefoot
Copy link
Contributor

ok thx! :)

You can also remove the NETSTANDARD1_3 code from AssemblyVersionLayoutRenderer.cs

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #232 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #232   +/-   ##
=====================================
- Coverage      59%    58%   -1%     
=====================================
  Files          29     29           
  Lines         395    395           
  Branches       92     92           
=====================================
- Hits          233    231    -2     
  Misses        126    126           
- Partials       36     38    +2
Impacted Files Coverage Δ
...e/LayoutRenderers/AssemblyVersionLayoutRenderer.cs 25% <ø> (ø) ⬆️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 80% <0%> (-4%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 96% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ace8c5...f7faa1e. Read the comment docs.

@304NotModified 304NotModified force-pushed the update-deps branch 2 times, most recently from 7f6950e to 3d751cf Compare December 5, 2017 22:24
@304NotModified 304NotModified merged commit e9b2d7c into master Dec 5, 2017
@304NotModified 304NotModified deleted the update-deps branch April 29, 2018 21:06
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET Core ASP.NET Core - all versions enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on System.ValueTuple for NetStandard 2.0 Update to NLog 4.5 RC2, drop NLog 5 references
2 participants