Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assembly-version #224

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Conversation

304NotModified
Copy link
Member

fixes #222 and fixes NLog/NLog#2428

thanks @snakefoot!

@snakefoot
Copy link
Contributor

snakefoot commented Nov 30, 2017

@304NotModified Maybe make this dependency NetStandard1.3 only (Removing it as dependency for NetStandard1.5 and net451)

<PackageReference Include="Microsoft.Extensions.PlatformAbstractions" Version="1.0.0" />

@304NotModified 304NotModified force-pushed the fix-assembly-version-renderer-net4.x branch from a25c6f5 to 6855a5a Compare November 30, 2017 22:55
@304NotModified
Copy link
Member Author

merci!

@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #224 into master will decrease coverage by <1%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #224    +/-   ##
======================================
- Coverage      59%    58%   -<1%     
======================================
  Files          29     29            
  Lines         397    395     -2     
  Branches       92     92            
======================================
- Hits          233    231     -2     
+ Misses        128    126     -2     
- Partials       36     38     +2
Impacted Files Coverage Δ
...e/LayoutRenderers/AssemblyVersionLayoutRenderer.cs 25% <0%> (+2%) ⬆️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 80% <0%> (-4%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 96% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04b4aa...6855a5a. Read the comment docs.

@304NotModified 304NotModified merged commit 6265c40 into master Nov 30, 2017
@304NotModified 304NotModified deleted the fix-assembly-version-renderer-net4.x branch November 30, 2017 23:17
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET Core ASP.NET Core - all versions bug
Projects
None yet
2 participants