Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AssemblyVersionLayoutRenderer docs for .NET core #162

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Update AssemblyVersionLayoutRenderer docs for .NET core #162

merged 1 commit into from
Jul 26, 2017

Conversation

abakumov-v
Copy link
Contributor

Fixed comments for Name property (for .NET Full and Standard results of layout renderer will be different)

@abakumov-v
Update AssemblyVersionLayoutRenderer.cs
5a887d9 
Fixed comments for Name property (for .NET Full and Standard results of layout renderer will be different)
@codecov
Copy link

codecov bot commented Jul 26, 2017 •
edited
Loading

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #162   +/-   ##
======================================
  Coverage    57.7%   57.7%           
======================================
  Files          29      29           
  Lines         383     383           
  Branches       92      92           
======================================
  Hits          221     221           
  Misses        125     125           
  Partials       37      37
Impacted Files Coverage Δ
...e/LayoutRenderers/AssemblyVersionLayoutRenderer.cs 25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abcf52...5a887d9. Read the comment docs.

@304NotModified 304NotModified changed the title Update AssemblyVersionLayoutRenderer.cs Update AssemblyVersionLayoutRenderer docs for .NET core Jul 26, 2017
@304NotModified 304NotModified added this to the NLog.Web.AspNetCore 4.4.1 milestone Jul 26, 2017
@304NotModified
Copy link
Member

304NotModified commented Jul 26, 2017 •
edited
Loading

Thanks! Could you please update also https://github.com/NLog/NLog/wiki/AssemblyVersion-Layout-Renderer? Thanks!

@304NotModified 304NotModified merged commit e6d1ffc into NLog:master Jul 26, 2017
@304NotModified 304NotModified modified the milestones: NLog.Web.AspNetCore 4.4.1 + NLog.Web 4.5.1, NLog.Web.AspNetCore 4.5 + NLog.Web 4.5.1 Sep 29, 2017
@abakumov-v
Copy link
Contributor Author

@304NotModified done! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
NLog.Web.AspNetCore 4.5 + NLog.Web 4...
Development

Successfully merging this pull request may close these issues.
2 participants
@abakumov-v @304NotModified