From cfd3d74ab5afc27bc8137503d5325fa6304a805d Mon Sep 17 00:00:00 2001 From: sushitommy <> Date: Mon, 16 Dec 2024 15:13:37 +0100 Subject: [PATCH 1/5] Fix Dialog component --- components/dialog/src/index.scss | 3 +++ .../src/theme/DocRoot/Layout/Sidebar/styles.module.css | 7 ------- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/components/dialog/src/index.scss b/components/dialog/src/index.scss index f646d60555..710d71e179 100644 --- a/components/dialog/src/index.scss +++ b/components/dialog/src/index.scss @@ -1,5 +1,6 @@ // Dialog .rvo-dialog { + border: none; box-sizing: border-box; display: flex; flex-direction: column; @@ -30,6 +31,7 @@ .rvo-dialog--drawer-left { height: 100vh; left: 0; + margin: initial; max-width: var(--rvo-dialog-drawer-max-width); min-width: var(--rvo-dialog-drawer-min-width); position: fixed; @@ -40,6 +42,7 @@ .rvo-dialog--drawer-right { height: 100vh; + margin: initial; max-width: var(--rvo-dialog-drawer-max-width); min-width: var(--rvo-dialog-drawer-min-width); position: fixed; diff --git a/packages/docusaurus/src/theme/DocRoot/Layout/Sidebar/styles.module.css b/packages/docusaurus/src/theme/DocRoot/Layout/Sidebar/styles.module.css index 87b1eb51bf..0e569b86bc 100644 --- a/packages/docusaurus/src/theme/DocRoot/Layout/Sidebar/styles.module.css +++ b/packages/docusaurus/src/theme/DocRoot/Layout/Sidebar/styles.module.css @@ -20,11 +20,4 @@ cursor: pointer; width: var(--doc-sidebar-hidden-width); } - - .sidebarViewport { - top: var(--ifm-navbar-height); - position: sticky; - height: 100%; - max-height: calc(100vh - 137px); - } } From 09c1b903e035a8503d373b366675bffa578e4545 Mon Sep 17 00:00:00 2001 From: sushitommy <> Date: Mon, 16 Dec 2024 15:14:20 +0100 Subject: [PATCH 2/5] Add changeset for Dialog --- .changeset/spotty-pumas-crash.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/spotty-pumas-crash.md diff --git a/.changeset/spotty-pumas-crash.md b/.changeset/spotty-pumas-crash.md new file mode 100644 index 0000000000..d07082cfa9 --- /dev/null +++ b/.changeset/spotty-pumas-crash.md @@ -0,0 +1,7 @@ +--- +"@nl-rvo/css-dialog": patch +"@nl-rvo/component-library-css": patch +"@nl-rvo/component-library-react": patch +--- + +Fixed Dialog border and margin From 767b12fa5a64c39210fc087fb4f8b81dc99f6cf8 Mon Sep 17 00:00:00 2001 From: sushitommy <> Date: Mon, 16 Dec 2024 15:23:23 +0100 Subject: [PATCH 3/5] Keep Docusaurus sidebar link color --- packages/docusaurus/src/theme/DocSidebarItem/Link/index.tsx | 2 ++ .../src/theme/DocSidebarItem/Link/styles.module.css | 4 ++++ 2 files changed, 6 insertions(+) create mode 100644 packages/docusaurus/src/theme/DocSidebarItem/Link/styles.module.css diff --git a/packages/docusaurus/src/theme/DocSidebarItem/Link/index.tsx b/packages/docusaurus/src/theme/DocSidebarItem/Link/index.tsx index 1ddd609ab7..1897c796f8 100644 --- a/packages/docusaurus/src/theme/DocSidebarItem/Link/index.tsx +++ b/packages/docusaurus/src/theme/DocSidebarItem/Link/index.tsx @@ -5,6 +5,7 @@ import useBaseUrl from '@docusaurus/useBaseUrl'; import { Link } from '@nl-rvo/components'; import type { Props } from '@theme/DocSidebarItem/Link'; import clsx from 'clsx'; +import styles from './styles.module.css'; export default function DocSidebarItemLink({ item, onItemClick, activePath, level, ...props }: Props): JSX.Element { const { href, label, className } = item; @@ -32,6 +33,7 @@ export default function DocSidebarItemLink({ item, onItemClick, activePath, leve {...props} showIcon={!isInternalLink ? 'after' : 'no'} icon={!isInternalLink ? 'externe-link' : undefined} + className={styles['sidebar-link']} > {label} diff --git a/packages/docusaurus/src/theme/DocSidebarItem/Link/styles.module.css b/packages/docusaurus/src/theme/DocSidebarItem/Link/styles.module.css new file mode 100644 index 0000000000..87e8abe08e --- /dev/null +++ b/packages/docusaurus/src/theme/DocSidebarItem/Link/styles.module.css @@ -0,0 +1,4 @@ +.sidebar-link:hover, +.sidebar-link:focus { + color: var(--rvo-color-grijs-700) !important; +} From a0026fb634d4619e1ce0d7d8975fffccf0d7d414 Mon Sep 17 00:00:00 2001 From: sushitommy <> Date: Mon, 16 Dec 2024 15:30:39 +0100 Subject: [PATCH 4/5] Don't overflow sidebar --- components/max-width-layout/src/defaultArgs.ts | 1 + components/max-width-layout/src/index.scss | 13 +++++++++++-- components/max-width-layout/src/template.tsx | 6 ++++++ 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/components/max-width-layout/src/defaultArgs.ts b/components/max-width-layout/src/defaultArgs.ts index 057de9382d..90de897288 100644 --- a/components/max-width-layout/src/defaultArgs.ts +++ b/components/max-width-layout/src/defaultArgs.ts @@ -5,4 +5,5 @@ export const defaultArgs: IMaxWidthLayoutProps = { content: 'Deze gecentreerde layout container heeft een maximale breedte van {maxWidth}.', centered: true, inlinePadding: 'none', + useAsMinWidthToo: true, }; diff --git a/components/max-width-layout/src/index.scss b/components/max-width-layout/src/index.scss index 299fba0ba0..be030b78f9 100644 --- a/components/max-width-layout/src/index.scss +++ b/components/max-width-layout/src/index.scss @@ -14,16 +14,25 @@ .rvo-max-width-layout--sm { max-width: var(--rvo-layout-max-width-sm); - min-width: var(--rvo-layout-max-width-sm); } .rvo-max-width-layout--md { max-width: var(--rvo-layout-max-width-md); - min-width: var(--rvo-layout-max-width-md); } .rvo-max-width-layout--lg { max-width: var(--rvo-layout-max-width-lg); +} + +.rvo-min-width-layout--sm { + min-width: var(--rvo-layout-max-width-sm); +} + +.rvo-min-width-layout--md { + min-width: var(--rvo-layout-max-width-md); +} + +.rvo-min-width-layout--lg { min-width: var(--rvo-layout-max-width-lg); } diff --git a/components/max-width-layout/src/template.tsx b/components/max-width-layout/src/template.tsx index b728451466..e463d1de28 100644 --- a/components/max-width-layout/src/template.tsx +++ b/components/max-width-layout/src/template.tsx @@ -15,6 +15,7 @@ export interface IMaxWidthLayoutProps { content?: string; inlinePadding?: 'none' | 'sm' | 'md' | 'lg'; centered?: boolean; + useAsMinWidthToo?: boolean; /** @uxpinignoreprop */ className?: string | string[]; /** @uxpinpropname Content */ @@ -29,6 +30,9 @@ export const argTypes = { content: { control: 'text', }, + useAsMinWidthToo: { + control: 'boolean', + }, centered: { control: 'boolean', }, @@ -48,6 +52,7 @@ export const MaxWidthLayout: React.FC = ({ content = defaultArgs.content, inlinePadding = defaultArgs.inlinePadding, centered = defaultArgs.centered, + useAsMinWidthToo = defaultArgs.useAsMinWidthToo, children, className = [], ...props @@ -75,6 +80,7 @@ export const MaxWidthLayout: React.FC = ({ className={clsx( 'rvo-max-width-layout', `rvo-max-width-layout--${size}`, + useAsMinWidthToo && `rvo-min-width-layout--${size}`, `rvo-max-width-layout-inline-padding--${inlinePadding}`, !centered && 'rvo-max-width-layout--uncentered', className, From 2ab08985df41730172c2c483566cf703a04702c0 Mon Sep 17 00:00:00 2001 From: sushitommy <> Date: Mon, 16 Dec 2024 16:25:08 +0100 Subject: [PATCH 5/5] Remove hover underline from full card title link --- .changeset/dull-shirts-wonder.md | 7 +++++++ components/card/src/index.scss | 4 ---- 2 files changed, 7 insertions(+), 4 deletions(-) create mode 100644 .changeset/dull-shirts-wonder.md diff --git a/.changeset/dull-shirts-wonder.md b/.changeset/dull-shirts-wonder.md new file mode 100644 index 0000000000..a5dfa71378 --- /dev/null +++ b/.changeset/dull-shirts-wonder.md @@ -0,0 +1,7 @@ +--- +"@nl-rvo/css-card": patch +"@nl-rvo/component-library-css": patch +"@nl-rvo/component-library-react": patch +--- + +Removed hover underline from full card title link diff --git a/components/card/src/index.scss b/components/card/src/index.scss index 1de90e5d50..83f25f4b02 100644 --- a/components/card/src/index.scss +++ b/components/card/src/index.scss @@ -148,10 +148,6 @@ display: block; text-decoration: none; - &:hover { - text-decoration: underline; - } - &::after { content: ""; cursor: pointer;