Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox + Checkbox group component #462

Closed
Robbert opened this issue Jul 31, 2024 · 3 comments
Closed

Checkbox + Checkbox group component #462

Robbert opened this issue Jul 31, 2024 · 3 comments
Assignees
@AdhamAH @Rozerinay

Comments

@Robbert
Copy link
Member

Robbert commented Jul 31, 2024 •
edited by Rozerinay
Loading

Figma
@Robbert Robbert converted this from a draft issue Jul 31, 2024
@Rozerinay
Copy link
Contributor

PR: #502

@MeesD94 MeesD94 self-assigned this Aug 15, 2024
@MeesD94 MeesD94 moved this from Design review to On hold in Community Sprint - Rijkshuisstijl componenten Aug 23, 2024
@Robbert Robbert moved this from On hold to In Progress in Community Sprint - Rijkshuisstijl componenten Sep 4, 2024
@Robbert Robbert assigned AdhamAH and unassigned MeesD94 Sep 4, 2024
@AdhamAH AdhamAH mentioned this issue Sep 11, 2024
Merged
@Rozerinay Rozerinay self-assigned this Sep 12, 2024
@Rozerinay
Copy link
Contributor

Design review: Checkbox

Bij de 'Disabled' en 'Invalid' state zie ik on hover dat de background-color verandert van kleur. Deze hoort dezelfde kleur te behouden.

@AdhamAH AdhamAH mentioned this issue Sep 13, 2024
Merged
@Rozerinay
Copy link
Contributor

Design review

Checkbox group:

  • Het Label ontbreekt bij deze component.

Form field checkbox:

  • De naam van deze component is 'Form field checkbox option'.
  • Er is bij het label een margin-block-end toegevoegd, terwijl dit niet in design is aangegeven. Waar komt deze vandaan? Ik zie dat de component daardoor ook in hoogte groter is (38px).
  • De gap is 12px. In design heeft het de spacing rhc.space.100 (8px).

Form field checkbox group:

  • Er lijkt geen row-gap te zijn ingesteld. In plaats daarvan is er op het label een margin-block-end toegepast. Hiermee is het anders in design.
  • Waar komt de story Status vandaan? Waarvoor hebben we deze nodig?
  • Ik vermoed dat Input dir anders hoort te heten.

@AdhamAH AdhamAH mentioned this issue Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdhamAH AdhamAH

@Rozerinay Rozerinay

Labels
None yet
Projects
Community Sprint - Rijkshuisstijl componenten
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Robbert @AdhamAH @MeesD94 @Rozerinay