New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand CI test matrix from Node 18 to 18/20/22 #413

Open

birkskyum opened this issue Nov 10, 2024 · 1 comment

Contributor

birkskyum commented Nov 10, 2024 •

edited

Loading

The CI currently only check Node 18:

vinxi/.github/workflows/test.yml

Line 30 in b0ccb64

node-version: [18]

The active and current LTS version of Node is Node 20/22.

I'm sure a lot of people, myself included, use these versions.

codebryo commented Nov 11, 2024

I fully agree.
Would even argue it would make sense for a project like Vinxi to drop official 18 support.

While Vite states 18 and 20+ are supported, the v18 support is getting less in the eco system.

Nitro officially only states latest LTS, so I guess that while 22 is the latest LTS, 20 will be supported for a longer period as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment