Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing DEVELOPMENT.md / CONTRIBUTING.md guides #411

Open
birkskyum opened this issue Nov 10, 2024 · 0 comments
Open

Missing DEVELOPMENT.md / CONTRIBUTING.md guides #411

birkskyum opened this issue Nov 10, 2024 · 0 comments

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Nov 10, 2024

It would be quite helpful to have some guides in this repo:

  • DEVELOPMENT.md: Guidance on who to run the repo
  • CONTRIBUTING.md: If contributions are welcome, and if so if there's something to be aware of like the @changesets/cli commit syntax, and who are currently active maintainers of the repo.

Before making modification, I want to see a green test pass. I attempt a build run, which returns me a message that there's no build scripts found:

➜ pnpm build

> vinxi-monorepo@ build /Users/admin/repos/vinxi
> pnpm -r --filter "./packages/*" run build

Scope: 13 of 43 workspace projects
None of the selected packages has a "build" script

Alright, so I go ahead with pnpm test, and it's just fails:


  Slow test file: [chromium] › hmr.test.ts (15.1s)
  Consider splitting slow test files to speed up parallel execution
  22 failed
    [chromium] › basic.test.ts:44:2 › basic-dev › hydrates ─────────────────────────────────────────
    [chromium] › basic.test.ts:44:2 › basic-prod › hydrates ────────────────────────────────────────
    [chromium] › fs-router.test.ts:60:2 › fs-router-dev › hydrates ─────────────────────────────────
    [chromium] › fs-router.test.ts:60:2 › fs-router-prod › hydrates ────────────────────────────────
    [chromium] › hmr.test.ts:85:2 › hmr › client hmr ───────────────────────────────────────────────
    [chromium] › multi-spa.test.ts:37:3 › multi-spa-dev › root ─────────────────────────────────────
    [chromium] › multi-spa.test.ts:37:3 › multi-spa-dev › react ────────────────────────────────────
    [chromium] › multi-spa.test.ts:37:3 › multi-spa-dev › solid ────────────────────────────────────
    [chromium] › multi-spa.test.ts:37:3 › multi-spa-prod › root ────────────────────────────────────
    [chromium] › multi-spa.test.ts:37:3 › multi-spa-prod › react ───────────────────────────────────
    [chromium] › multi-spa.test.ts:37:3 › multi-spa-prod › solid ───────────────────────────────────
    [chromium] › multi-spa.test.ts:153:3 › multi-spa-mode-backwards-compat-dev › root ──────────────
    [chromium] › multi-spa.test.ts:153:3 › multi-spa-mode-backwards-compat-dev › react ─────────────
    [chromium] › multi-spa.test.ts:153:3 › multi-spa-mode-backwards-compat-dev › solid ─────────────
    [chromium] › multi-spa.test.ts:153:3 › multi-spa-mode-backwards-compat-prod › root ─────────────
    [chromium] › multi-spa.test.ts:153:3 › multi-spa-mode-backwards-compat-prod › react ────────────
    [chromium] › multi-spa.test.ts:153:3 › multi-spa-mode-backwards-compat-prod › solid ────────────
    [chromium] › rsc.test.ts:36:2 › rsc › spa ──────────────────────────────────────────────────────
    [chromium] › srv-fn.test.ts:32:2 › srv-fn-dev › spa ────────────────────────────────────────────
    [chromium] › srv-fn.test.ts:32:2 › srv-fn-prod › spa ───────────────────────────────────────────
    [chromium] › to-web-request.test.ts:32:2 › toWebRequest-dev › readBody call after toWebRequest does not block 
    [chromium] › to-web-request.test.ts:32:2 › toWebRequest-prod › readBody call after toWebRequest does not block 
  12 passed (1.0m)

I'm not sure what's causing this.

@birkskyum birkskyum changed the title Missing CONTRIBUTING.md Missing DEVELOPMENT.md or CONTRIBUTING.md guide Nov 10, 2024
@birkskyum birkskyum changed the title Missing DEVELOPMENT.md or CONTRIBUTING.md guide Missing CONTRIBUTING.md guide Nov 10, 2024
@birkskyum birkskyum changed the title Missing CONTRIBUTING.md guide Missing DEVELOPMENT.md / CONTRIBUTING.md guide Nov 10, 2024
@birkskyum birkskyum changed the title Missing DEVELOPMENT.md / CONTRIBUTING.md guide Missing DEVELOPMENT.md / CONTRIBUTING.md guides Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant