The output pane always shows fork/exec : no such file or directory

[neilco]

Summary:

The output pane always shows fork/exec : no such file or directory.

Steps to Reproduce:

• Download the v0.1.0 DMG
• Install Ginker into /Applications
• Run Ginker
• Set the Golang Binary path to /usr/local/go/bin/go in preferences (because it was empty)
• Modify the string argument to fmt.Println.

Environment:

• macOS 11.3.1 (Big Sur)
• Go 1.16.4 (installed from official package)

Expected Outcome:

• The output pane shows the modified string

Actual Outcome:

• The output pane shows fork/exec : no such file or directory.

[nkoporec]

I suspect that the 'Golang binary' path does not work correctly on Mac OS, since it was empty as first. I'm using it on my workstation(linux) and the go path does get populated at startup.I will try to replicate the issue on my mac later in the day.

[neilco]

This line shows that the "darwin" case is empty and this explains why the Golang Binary path is empty under macOS. It will not fall through to the "linux" case, which is what I suspect you intend. The right way is shown below:

switch os := runtime.GOOS; os {
case "darwin":
  fallthrough
case "linux":
  cmd := exec.Command("which", "go")
  stdout, err := cmd.Output()

  if err != nil {
  }
  goBinary = string(stdout)
}

An alternative approach is shown here:

switch os := runtime.GOOS; os {
case "darwin", "linux":
  cmd := exec.Command("which", "go")
  stdout, err := cmd.Output()

  if err != nil {
  }
  goBinary = string(stdout)
}

[nkoporec]

Yep you were right, the switch case was ignored. I published a new release where this is fixed + the gobinary path should also work now.

Let me know, if it works.

[neilco]

I removed my Ginker config (rm -rf ~/.ginker) and ran v0.1.1. The issue remained, so I did some digging...

Fun fact: Forking a child process from within macOS app bundle does not inherit the environment of the user that launched the app bundle 🤦

I got it working by appending $GOROOT/bin to $PATH:

switch runtime.GOOS {
case "darwin", "linux":
  // Configure $PATH with a sensible default
  defaultGoBin := filepath.Clean(path.Join(runtime.GOROOT(), "bin"))
  os.Setenv("PATH", fmt.Sprintf("%s:%s", os.Getenv("PATH"), defaultGoBin))
  
  cmd := exec.Command("which", "go")
  stdout, err := cmd.Output()

  if err != nil {
  }
  goBinary = string(stdout)
}

A safer approach would be this:

switch runtime.GOOS {
case "darwin", "linux":  
  cmd := exec.Command("which", "go")
  stdout, err := cmd.Output()

  if err != nil {
  }
  goBinary = string(stdout)
  if goBinary == "" && runtime.GOROOT() != "" {
    goBinary = filepath.Clean(path.Join(runtime.GOROOT(), "bin", "go"))
  }
}

[nkoporec]

Nice, did not think of running the app inside the app bundle. I committed your suggestions to the master branch 👍