From b9af963f9b39344abcd44c7b4877fd73c7804b16 Mon Sep 17 00:00:00 2001 From: Namrata Kodali Date: Thu, 12 Nov 2020 17:53:11 -0500 Subject: [PATCH] roachprod: dismiss signup banner for nodes started by roachprod Previously, when starting a node using roachprod, the db console ui would display a release notes signup banner. This banner is not useful for users of roachprod. We introduced a way to toggle this via env var in #56437. This commit sets that env var, COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED=true for `cockroach start*` commands issued from roachprod. Resolves: #46998 See also: #56437 Release note: none --- pkg/cmd/roachprod/install/cockroach.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/cmd/roachprod/install/cockroach.go b/pkg/cmd/roachprod/install/cockroach.go index a8ac7216c503..e2c834243701 100644 --- a/pkg/cmd/roachprod/install/cockroach.go +++ b/pkg/cmd/roachprod/install/cockroach.go @@ -385,6 +385,7 @@ func (h *crdbInstallHelper) generateStartCmd( [ -x /usr/bin/lslocks ] && /usr/bin/lslocks >> %[1]s/roachprod.log; %[2]s export ROACHPROD=%[3]d%[4]s; GOTRACEBACK=crash COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1 %[5]s \ + COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED=true \ %[6]s %[7]s %[8]s >> %[1]s/cockroach.stdout.log \ 2>> %[1]s/cockroach.stderr.log \ || (x=$?; cat %[1]s/cockroach.stderr.log; exit $x)`,