Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject build requires build-system definition #119

Open
mweinelt opened this issue May 7, 2023 · 3 comments
Open

pyproject build requires build-system definition #119

mweinelt opened this issue May 7, 2023 · 3 comments
Labels
bug Something isn't working python

Comments

@mweinelt
Copy link
Member

mweinelt commented May 7, 2023

A pyproject.toml file is only useful for building a python project, when it has a build-system section and a build-backend defined.

https://github.com/dfunckt/django-rules/blob/master/pyproject.toml
✔️ https://github.com/pyca/cryptography/blob/main/pyproject.toml#L1-L10

Don't offer it, when the section does not exist.

@figsoda figsoda added bug Something isn't working python labels May 7, 2023
@figsoda
Copy link
Member

figsoda commented May 31, 2023

https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/#fallback-behaviour

Perhaps it should just recommend setuptools over pyproject if it is absent?

@mweinelt
Copy link
Member Author

Apparently you can just use pyproject format if no build-system is present, but either setup.cfg or setup.py are. In either case you then need setuptools in nativeBuildInputs.

@figsoda
Copy link
Member

figsoda commented Jun 29, 2023

In either case you then need setuptools in nativeBuildInputs.

fixed in 22e325b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

No branches or pull requests

2 participants