-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jujutsu: support darwin guidelines for config placement #5416
jujutsu: support darwin guidelines for config placement #5416
Conversation
Could someone hint me on what's wrong with the test ? |
LGTM, but I'm not sure about the tests either... |
For the tests: I'm getting |
I just forgot to escape the space in |
49676ec
to
9663ce3
Compare
@huwaireb Could you please rerun the tests with the latest commit? I don't know why, the CI gives cryptic errors. |
erm, wut?
The CI seems to be giving out unrelated errors? External messages
|
373828d
to
7531921
Compare
MacOS CI seems to be broken for the past ~3-4 days? Due to swift-5.8. Found a mention to what could be the culprit: requires a nixpkgs fix. opened an home-manager issue, see #5550. |
the above has been fixed, and it should be available in the latest locked nixpkgs in master. i think if @mrnossiom merges/rebases master then the swift build failure shouldn't cause ci to fail |
7531921
to
1deda06
Compare
Follow up to nix-community#5207, fixing jujutsu module on darwin targets.
1deda06
to
a163795
Compare
Thanks! Squashed and merged to master now 🙂 |
Follow up to #5207, fixing jujutsu module on darwin targets.
Closes #5544 (duplicate)
Description
If the module is evaluated on a Darwin platform, place config in
Library/Application Support
instead of unsupported XDG directory.If someone could test it on Darwin, it would be great (e.g. @bnjmnt4n) :
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
Maintainer CC
@shikanime