brave: fix config dir path #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes install path for extensions from `~/.config/brave` to `~/.config/BraveSoftware/Brave-Browser` on Linux.
|
That was fast! Thanks y'all. |
|
Anyway to get this merged into 21.05 ? Thanks |
|
@yisraeldov I think you can just submit a PR against the |
|
rycee
pushed a commit
that referenced
this pull request
Jul 30, 2021
Changes install path for extensions from `~/.config/brave` to `~/.config/BraveSoftware/Brave-Browser` on Linux. (cherry picked from commit 9e3c402)
|
I've cherry-picked the commit to release-21.05 in b39647e. Please give it a try. |
|
Great! This works now as expected on brave! Is there a way to get it to work for multiple browsers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Not if the user overrides
programs.brave.packagewith an older version of Brave.Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.