Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offlineimap: Strip newlines from offlineimap passwordcommand #1853

Merged

Conversation

erictapen
Copy link
Contributor

Description

This allows me to use offlineimap with passwordstore. I guess nobody uses a newline in their password?

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

Tests seem to be broken atm? attribute 'anything' missing

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

This allows me to use offlineimap with passwordstore. I guess nobody
uses a newline in their password?
@erictapen erictapen requested a review from rycee as a code owner March 8, 2021 11:33
Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

This looks fairly benign.
The Arch wiki has multiple examples with strip() so I assume this is one of those cases.

@berbiche berbiche merged commit 040ea28 into nix-community:master Mar 10, 2021
cab404 pushed a commit to cab404/home-manager that referenced this pull request Apr 23, 2021
…munity#1853)

This allows me to use offlineimap with passwordstore. I guess nobody
uses a newline in their password?

Co-authored-by: Kerstin Humm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants