Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseeffects: add option to specify package #1825

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

moni-dz
Copy link
Contributor

@moni-dz moni-dz commented Feb 23, 2021

Description

Fix #1824 by adding an option to specify the pulseeffects package

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@berbiche berbiche merged commit e7b1491 into nix-community:master Feb 23, 2021
@berbiche
Copy link
Member

Thanks for the contribution!

@moni-dz moni-dz deleted the fix-pulseeffects-package branch February 23, 2021 22:47
malte-v pushed a commit to malte-v/home-manager that referenced this pull request Feb 24, 2021
aakropotkin pushed a commit to aakropotkin/home-manager that referenced this pull request Feb 28, 2021
thiagokokada pushed a commit to thiagokokada/home-manager that referenced this pull request Mar 1, 2021
thiagokokada pushed a commit to thiagokokada/home-manager that referenced this pull request Mar 4, 2021
cab404 pushed a commit to cab404/home-manager that referenced this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThrownError when enabling services.pulseeffects
2 participants