firefox: drop enableAdobeFlash option

[mweinelt]

Description

Drop the enableAdobeFlash option for firefox.

It was removed in nixpkgs (NixOS/nixpkgs#112335) and now causes an error on rebuilds.

error: Your configuration mentions firefox.enableAdobeFlash. All plugin related options have been removed, since Firefox from version 52 onwards no longer supports npapi plugins (see https://support.mozilla.org/en-US/kb/npapi-plugins).

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

  • sans the newsboat test

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

  • Added myself and the module files to .github/CODEOWNERS.

[berbiche]

home-manager/modules/programs/firefox.nix

Lines 69 to 74 in 6cccbbf

	imports = [
	(mkRemovedOptionModule ["programs" "firefox" "enableGoogleTalk"]
	"Support for this option has been removed.")
	(mkRemovedOptionModule ["programs" "firefox" "enableIcedTea"]
	"Support for this option has been removed.")
	];

Can you add an (mkRemovedOptionModule [ "programs" "firefox" "enableAdobeFlash" ] "Support for this option has been removed.") in the imports above?

[mweinelt]

Done, thanks for the feedback.

[berbiche]

Thanks for the contribution!