-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: DocBook validation errors on Darwin #4142
Comments
You updated to what version? Did you run |
Yes, I run: The output is:
|
cc @pennae, since this class of errors has historically been following nixpkgs changes, and you were de-docbookifying things recently. |
the error message from schema validation is (unsurprisingly) not very useful. we'd guess that the actual error as a good distance away in the xml file, would need the file to find out. given that the home-manager docs system is neither fully nixpkgs nor fully its own we're not even sure we can do anything to resolve this |
My current guess (still investigating) is the change to |
Couldn't reproduce in CI. :( @takeda could you share the contents of |
Here's my manual-combined.xml file (in a ZIP archive to satisfy GitHub's file upload restrictions). |
Here's my manual-combined.xml.gz |
From what I can tell <para><simpara><varname>lib</varname>: The nixpkgs library.</simpara>
</para> I've seen this before and thought it was fixed. I'll have a look at what has changed. @takeda Meanwhile, could you make certain that you are using an up to date version of Home Manager? |
It looks like #3680 (comment) still applies. |
Finally managed to reproduce this. It happens iff using a post-NixOS/nixpkgs#237557 nixpkgs (so, as of now, any unstable channel) AND |
So the underlying problem is still the same: HM is not ready to properly render |
Yes, we've also run into this in nix-darwin. I am working on moving nix-darwin over to using the new upstream NixOS options processor and documentation generator; it is quite easy and removes a lot of duplicated code and complexity, and the old DocBook options can be converted to Markdown automatically. Would Home Manager be interested in moving from |
Yes yes yes yes yes please yes. |
lol, noted :) I have to finish off nix-darwin first, and Home Manager has an actual manual and not just configuration docs, so it'll probably be a few days. In the meantime I would recommend affected users temporarily disable |
I can confirm that disabling this option in my home.nix file allows me to get past this problem, and on to the next problem. |
@rycee I run If there's a way to do a double check it somehow (like maybe I can get the git hash for each channel) then let me know and I check. But those channels should be latest as of yesterday. |
@takeda it's fine, we've confirmed the bug is with the latest versions. |
@takeda Could you try pulling the latest home-manager master now and see if the documentation builds? |
Fwiw it fixed it for me. Thanks. |
@hraban Thanks a lot! Would you mind trying it once more? I made a slightly different solution that should be better. |
@rycee this version works as well:
|
@hraban Excellent, thanks a lot for trying it out! I'll close this issue with the hope that it is not just working for you. If anybody still have problems, please reopen the issue. |
Are you following the right branch?
Is there an existing issue for this?
Issue description
I updated nix-darwin, home-manager and nixpkgs and after that it refuses to build due to issues with manpages:
Here's output of
nix log /nix/store/njjcgh3bkc8p0md376m1y00vp7j96yg8-manual-combined.drv
Maintainer CC
No response
System information
The text was updated successfully, but these errors were encountered: