Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neovim test is broken #1942

Closed
berbiche opened this issue Apr 23, 2021 · 3 comments · Fixed by #1943
Closed

Neovim test is broken #1942

berbiche opened this issue Apr 23, 2021 · 3 comments · Fixed by #1943

Comments

@berbiche
Copy link
Member

Issue description

@teto I think your recent change to neovim in nixpkgs broke one of the test case.

See the build log in https://github.com/nix-community/home-manager/pull/1939/checks#step:7:1669 and #1941

neovim-plugin-config: FAILED
Expected /dev/fd/63 to be same as /nix/store/1hm86ygdj96jh1105bm4zfn584wmsvan-plugin-config.vim but were different:
--- actual
+++ expected
@@ -0,0 +1,22 @@
+" configuration generated by NIX
+set nocompatible
+
+
+
+
+
+
+set packpath^=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-vim-pack-dir
+set runtimepath^=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-vim-pack-dir
+
+filetype indent plugin on | syn on
+
+
+" This should be present in vimrc
+" vim-commentary {{{
+" This should be present too
+autocmd FileType c setlocal commentstring=//\ %s
+autocmd FileType c setlocal comments=://
+
+" }}}
+
For further reference please introspect /nix/store/l0pwmyf3s7gl8wy99j6mjx6hl7vnvrkq-nmt-report-neovim-plugin-config

Meta

@teto @mjlbach

Maintainer CC

Technical details

@berbiche berbiche added the bug label Apr 23, 2021
@teto
Copy link
Collaborator

teto commented Apr 23, 2021

Yeah it's to be expected, the filetype indent plugin on | syn on should have disappeared and possibly the

+" configuration generated by NIX
+set nocompatible

too

EDIT: I tried to put up a quick fix but it doesn't seem to generate a file at all ? will investiage when I have more time

@teto
Copy link
Collaborator

teto commented Apr 23, 2021

@rycee is that diff normal ? Looks like it is comparing against an empty file even though the init.vim exists and is generated.

@sumnerevans
Copy link
Member

What does the assertFileExists function do? Maybe it gobbles up the stream from the stdin redirection before the diff that gets shown to the user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants