Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix subscriptions and add bucket notifications #106

Merged
merged 2 commits into from
May 17, 2023

Conversation

HomelessDinosaur
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 89.13% and project coverage change: +20.00 🎉

Comparison is base (d6e19d6) 71.91% compared to head (e35bd28) 91.91%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #106       +/-   ##
============================================
+ Coverage    71.91%   91.91%   +20.00%     
============================================
  Files           32       23        -9     
  Lines         2300     1460      -840     
============================================
- Hits          1654     1342      -312     
+ Misses         646      118      -528     
Impacted Files Coverage Δ
nitric/exception.py 100.00% <ø> (ø)
nitric/faas.py 79.83% <ø> (-1.19%) ⬇️
nitric/resources/apis.py 100.00% <ø> (+58.04%) ⬆️
nitric/resources/base.py 85.10% <ø> (+1.77%) ⬆️
nitric/resources/buckets.py 80.00% <ø> (-14.29%) ⬇️
nitric/resources/collections.py 93.93% <ø> (ø)
nitric/resources/queues.py 94.11% <ø> (ø)
nitric/resources/schedules.py 96.77% <ø> (+63.44%) ⬆️
nitric/resources/secrets.py 94.11% <ø> (ø)
nitric/resources/topics.py 82.50% <ø> (-4.68%) ⬇️
... and 6 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HomelessDinosaur HomelessDinosaur merged commit deb42f4 into develop May 17, 2023
@HomelessDinosaur HomelessDinosaur deleted the feat/bucket-notifications branch May 17, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants