Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(awstf): support SSM resource resolution with AWS Terraform #707

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jyecusch
Copy link
Member

@jyecusch jyecusch commented Dec 9, 2024

Tagging resolution is still supported by setting the environment variable NITRIC_AWS_RESOURCE_RESOLVER=tagging for backwards compatibility/opt-out

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.88%. Comparing base (34e85a8) to head (a161b8e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   48.88%   48.88%           
=======================================
  Files          28       28           
  Lines        3549     3549           
=======================================
  Hits         1735     1735           
  Misses       1695     1695           
  Partials      119      119           
Flag Coverage Δ
aws 44.82% <ø> (ø)
azure 53.29% <ø> (ø)
core 60.76% <ø> (ø)
gcp 47.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it needs a rebase

@jyecusch jyecusch merged commit 40fb680 into main Dec 9, 2024
4 checks passed
@jyecusch jyecusch deleted the fix/awstf-ssm branch December 9, 2024 23:33
@nitric-bot
Copy link

🎉 This PR is included in version 1.16.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants