Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcp): add cloud run cpu service configuration. #653

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Jul 30, 2024

No description provided.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (f846ae9) to head (ea419b1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   49.24%   49.21%   -0.04%     
==========================================
  Files          23       23              
  Lines        3233     3233              
==========================================
- Hits         1592     1591       -1     
  Misses       1537     1537              
- Partials      104      105       +1     
Flag Coverage Δ
aws 43.75% <ø> (-0.08%) ⬇️
azure 53.29% <ø> (ø)
core 77.88% <ø> (ø)
gcp 47.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjholm tjholm changed the title feat(gcp): add cloud run cpu service configuration. fix(gcp): add cloud run cpu service configuration. Jul 30, 2024
Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to remove the TODO comment

cloud/gcp/deploytf/.nitric/modules/service/main.tf Outdated Show resolved Hide resolved
@tjholm tjholm requested a review from davemooreuws July 30, 2024 04:22
@davemooreuws davemooreuws merged commit ffb49b5 into main Jul 30, 2024
4 checks passed
@davemooreuws davemooreuws deleted the feat/configure-cr-cpus branch July 30, 2024 04:49
@nitric-bot
Copy link

🎉 This PR is included in version 1.11.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants