Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): Resource Group Imports #648

Merged
merged 5 commits into from
Jul 23, 2024
Merged

feat(azure): Resource Group Imports #648

merged 5 commits into from
Jul 23, 2024

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Jul 22, 2024

Allows configuration of an existing resource group by adding

resource-group: <resource-group-name>

To a nitric azure stack file. Currently the resource group must reside in the same subscription the existing client is configured to deploy with.

cloud/azure/deploy/config.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (213c850) to head (90da056).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   49.21%   49.21%           
=======================================
  Files          23       23           
  Lines        3233     3233           
=======================================
  Hits         1591     1591           
  Misses       1537     1537           
  Partials      105      105           
Flag Coverage Δ
aws 43.75% <ø> (ø)
azure 53.29% <ø> (ø)
core 77.88% <ø> (ø)
gcp 47.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjholm tjholm merged commit 8dbddb7 into main Jul 23, 2024
4 checks passed
@tjholm tjholm deleted the feat/az-rg-import branch July 23, 2024 03:21
@nitric-bot
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants