Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): Allow HCL rendering. #640

Merged
merged 4 commits into from
Jul 15, 2024
Merged

fix(aws): Allow HCL rendering. #640

merged 4 commits into from
Jul 15, 2024

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Jul 15, 2024

Enables rendering AWS main module terraform output in HCL, by moving api spec outputs to a file referenced as a terraform asset.

To test hcl output run SYNTH_HCL_OUTPUT=true nitric up (HCL config flags do not currently work in cdktf).

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.24%. Comparing base (37a4af8) to head (e53c99e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
+ Coverage   49.21%   49.24%   +0.03%     
==========================================
  Files          23       23              
  Lines        3233     3233              
==========================================
+ Hits         1591     1592       +1     
  Misses       1537     1537              
+ Partials      105      104       -1     
Flag Coverage Δ
aws 43.82% <ø> (+0.07%) ⬆️
azure 53.29% <ø> (ø)
core 77.88% <ø> (ø)
gcp 47.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjholm tjholm merged commit 96f8ff8 into main Jul 15, 2024
4 checks passed
@tjholm tjholm deleted the fix/aws-hcl-output branch July 15, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants