Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add env variable to worker timeout configuration. #618

Merged
merged 1 commit into from
May 27, 2024

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented May 23, 2024

Add WORKER_TIMEOUT to allow for the configuration of nitric gateway timeout when waiting for workers to connect.

@tjholm tjholm requested a review from jyecusch as a code owner May 23, 2024 02:15
@tjholm tjholm force-pushed the configurable-timeout branch from a32f66c to 85ba92c Compare May 27, 2024 03:16
@tjholm tjholm force-pushed the configurable-timeout branch from 85ba92c to 97546b4 Compare May 27, 2024 03:20
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 49.22%. Comparing base (15c1b16) to head (85ba92c).

Current head 85ba92c differs from pull request most recent head 97546b4

Please upload reports for the commit 97546b4 to get more accurate results.

Files Patch % Lines
core/pkg/membrane/membrane.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
- Coverage   49.24%   49.22%   -0.02%     
==========================================
  Files          23       23              
  Lines        3229     3232       +3     
==========================================
+ Hits         1590     1591       +1     
- Misses       1535     1537       +2     
  Partials      104      104              
Flag Coverage Δ
aws 43.82% <ø> (+0.07%) ⬆️
azure 53.29% <ø> (ø)
core 77.77% <50.00%> (-1.10%) ⬇️
gcp 47.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjholm tjholm merged commit 811df85 into main May 27, 2024
2 checks passed
@tjholm tjholm deleted the configurable-timeout branch May 27, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant