-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Azure Schedules #438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjholm
force-pushed
the
dapr-azure-schedules
branch
3 times, most recently
from
May 25, 2023 05:46
ebb013f
to
8c8e1f4
Compare
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
tjholm
force-pushed
the
dapr-azure-schedules
branch
from
May 25, 2023 06:15
7080600
to
97b6f0e
Compare
Is this ready @tjholm |
jyecusch
previously requested changes
Aug 28, 2023
tjholm
force-pushed
the
dapr-azure-schedules
branch
from
August 29, 2023 22:54
97b6f0e
to
f5b7b93
Compare
tjholm
force-pushed
the
dapr-azure-schedules
branch
from
August 29, 2023 23:04
6fc0b4d
to
65f5cb7
Compare
davemooreuws
approved these changes
Sep 3, 2023
HomelessDinosaur
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to determine scaling rules with the application to get this style of scheduling working consistently.
Currently once the app has scaled to zero events will no longer be sent.
Need to define some KEDA cron scale rules in future to scale up prior to schedule fireing and to scale down after as well. For now containerapps that contain schedules will have their minimum replicas set to 1.