Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Azure Schedules #438

Merged
merged 4 commits into from
Sep 4, 2023
Merged

feat: Azure Schedules #438

merged 4 commits into from
Sep 4, 2023

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented May 7, 2023

Need to determine scaling rules with the application to get this style of scheduling working consistently.

Currently once the app has scaled to zero events will no longer be sent.

Need to define some KEDA cron scale rules in future to scale up prior to schedule fireing and to scale down after as well. For now containerapps that contain schedules will have their minimum replicas set to 1.

@tjholm tjholm force-pushed the dapr-azure-schedules branch 3 times, most recently from ebb013f to 8c8e1f4 Compare May 25, 2023 05:46
@tjholm tjholm marked this pull request as ready for review May 25, 2023 05:48
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
cloud/azure/runtime/gateway/http.go 0.00%

📢 Thoughts on this report? Let us know!.

@tjholm tjholm force-pushed the dapr-azure-schedules branch from 7080600 to 97b6f0e Compare May 25, 2023 06:15
@davemooreuws
Copy link
Member

Is this ready @tjholm

cloud/azure/deploy/up.go Outdated Show resolved Hide resolved
cloud/azure/deploy/schedule/dapr.go Outdated Show resolved Hide resolved
cloud/azure/deploy/schedule/dapr.go Show resolved Hide resolved
cloud/azure/deploy/schedule/dapr.go Outdated Show resolved Hide resolved
cloud/azure/deploy/schedule/dapr.go Outdated Show resolved Hide resolved
cloud/azure/deploy/schedule/dapr.go Outdated Show resolved Hide resolved
@tjholm tjholm force-pushed the dapr-azure-schedules branch from 97b6f0e to f5b7b93 Compare August 29, 2023 22:54
@tjholm tjholm force-pushed the dapr-azure-schedules branch from 6fc0b4d to 65f5cb7 Compare August 29, 2023 23:04
@tjholm tjholm requested a review from jyecusch August 29, 2023 23:04
@tjholm tjholm merged commit 0c98371 into develop Sep 4, 2023
@tjholm tjholm deleted the dapr-azure-schedules branch September 4, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants