-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable timeout for initializing the extension? #51
Comments
Oops! Sorry for that. I am going to work on the next release that will hopefully fix this issue. |
Heya, I've released a new version of the observer hook. Install the new beta with
Configure the timeout value like this - registerObserver({ timeout: desire_value_in_number }) Let me know if it works and then I'll go ahead and update the docs. |
Wow @nitin42, that was ridiculously fast. I'll give it a shot! |
Did you got it working with the new beta release ? |
finally about to try it, @nitin42. I'll let you know ASAP |
Awesome! |
@nitin42, I just tried it with the Chrome extension (v5.5), and it's still doing the same thing. I set a timeout of |
Hm... Strange! Can you show me a screenshot where you are using the observer hook ? |
Also, if it gives the error after two sec. then I am sure you must be using [email protected] and not @3.1.8-beta.2! |
It's perfectly working... see this video where I am using the current beta on my machine. I am adjusting the timeout value that directly impacts the initialisation process - video source Please make sure that you've |
I'll doublecheck and get back to you ASAP |
Strange! Are you doing server side rendering or using any server side React framework ? |
I've released a stable version I've thoroughly tested the build on three of my websites and apps built with React and I can confirm that everything is working fine. Closing this issue since the new release adds the timeout value property. But if still there is any issue, feel free to open it. |
@nitin42, we're definitely not doing any server-side rendering. Perhaps we're doing something else that the tool doesn't like. What are the general assumptions that the tool expects? Perhaps my problem isn't actually related to the timeout -- it could be a different error condition, but it doesn't look like I have a way to see the errors. Perhaps you can log errors to the console (or have an option to enable console error logging) |
@nitin42 I am having the same issue as @jrnail23 . Sometimes the devtools waits the full timeout length before showing me the performance statistics. Othertimes, it does not wait the timeout length and just shows the error message. It appears to work inconsistently. I am not doing server side rendering or using any server side React framework. |
Hi, I'm trying to get the chrome extension working, but it keeps telling me this:
I have installed the observer hook, and I definitely am using React, but my app does take a ridiculously long time to load (one of the reasons we need a good react profiler so badly!), so I suspect your extension's initialization may be timing out before my app is loaded. If that is the case, perhaps you could make that timeout configurable?
The text was updated successfully, but these errors were encountered: