Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem in SnackbarType.MULTI_LINE #50

Closed
nitinmishra27 opened this issue Dec 22, 2014 · 6 comments
Closed

Problem in SnackbarType.MULTI_LINE #50

nitinmishra27 opened this issue Dec 22, 2014 · 6 comments
Labels
bug

Comments

@nitinmishra27
Copy link
Contributor

First of all thanks for your work, i tried and came to know SnackbarType.MULTI_LINE isn't making any effect on device with physical screen size greater than 6.0". I'm using Sony's T2 Ultra and the SnackbarType.MULTI_LINE turn into an ellipsized text, and in smaller screen devices, it's working good.

Help is needed and appreciated
Thanks
@wmora
Copy link
Contributor

wmora commented Dec 22, 2014

screenshots?

@nitinmishra27
Copy link
Contributor Author

screenshot_2014-12-22-19-38-14

@nitinmishra27
Copy link
Contributor Author

screenshot_2014-12-22-20-26-28

@wmora
Copy link
Contributor

wmora commented Dec 23, 2014

The lib is considering 6" a tablet and it's wrong, should be 7 (boolean value should be in values-xlarge instead of values-large). I could fix later this week, but feel free to submit a PR before and I'll release a version right away

@wmora wmora added the bug label Dec 23, 2014
@nitinmishra27
Copy link
Contributor Author

@wmora I've created a pull request, when you've time please merge.

@wmora
Copy link
Contributor

wmora commented Dec 24, 2014

closed via #55. The sample app should be up in a bit with the updated lib. Let me know if it works

@wmora wmora closed this as completed Dec 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wmora @nitinmishra27