Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CONTRIBUTING.md #10

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Create CONTRIBUTING.md #10

merged 1 commit into from
Oct 11, 2023

Conversation

nick-y-ito
Copy link
Member

@nick-y-ito nick-y-ito commented Oct 10, 2023 •
edited
Loading

Overviews of implementation

Created CONTRIBUTING.md

Review points

  • The "Testing" and "Pull Request" sections may need to be reconsidered

@nick-y-ito nick-y-ito added documentation Improvements or additions to documentation internal labels Oct 10, 2023
@nick-y-ito nick-y-ito added this to the Basic Development milestone Oct 10, 2023
@nick-y-ito nick-y-ito self-assigned this Oct 10, 2023
hitohata
hitohata approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@hitohata hitohata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nick-y-ito nick-y-ito merged commit c53a8ba into develop Oct 11, 2023
1 check passed
@nick-y-ito nick-y-ito deleted the docs/2-contributing-md branch October 11, 2023 16:02
@nick-y-ito nick-y-ito linked an issue Oct 13, 2023 that may be closed by this pull request
Create CONTRIBUTING.md #2
Closed
@nick-y-ito nick-y-ito mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hitohata hitohata hitohata approved these changes

@yukiyohure yukiyohure Awaiting requested review from yukiyohure

@taniguchiiqqq taniguchiiqqq Awaiting requested review from taniguchiiqqq

Assignees

@nick-y-ito nick-y-ito

Labels
documentation Improvements or additions to documentation
Projects
Nishiki
Status: ✅ Done
Milestone
Basic Development
Development

Successfully merging this pull request may close these issues.

Create CONTRIBUTING.md
2 participants
@nick-y-ito @hitohata